Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
22 Jul 2020 at 08:45 UTC
Updated:
23 Aug 2020 at 21:29 UTC
Jump to comment: Most recent
Comments
Comment #2
harishh commentedHi @robindh
Please add hook_help
Comment #3
harishh commentedComment #4
robindh commentedHi, thanks for the quick reply + the composer.json patch.
I've added a hook_help implementation on the 8.x-1.x branch.
Comment #5
shaktikHi @robindh,
Thank for your contribution!
Kindly fix the below warning.
https://git.drupalcode.org/project/simple_live_css/-/blob/8.x-1.x/simple...
https://git.drupalcode.org/project/simple_live_css/-/blob/8.x-1.x/simple...
Comment #6
avpadernoComment #7
robindh commented@shaktik thanks, fixed on 8.x-1.x.
Comment #8
harishh commentedLooks good. Ready for RTBC
Comment #9
harishh commentedComment #10
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #11
robindh commentedThanks! Does this mean I should be able to opt into security advisory coverage for the simple live css module? I went to its edit page, but the radio button is still grayed out + a message underneath it says: "You must be given access to opt into security advisory coverage."
Comment #12
avpadernoOK, now you should. I apologize: The vetted role was not assigned.