Bootstrap storybook is an opinionated component-based base theme with built-in support for StorybookJS, Bootstrap 4 and BrowserSync out of the box

Project link

https://www.drupal.org/project/bootstrap_storybook

Git instructions

git clone --branch 3.1.x https://git.drupalcode.org/project/bootstrap_storybook.git

CommentFileSizeAuthor
#2 code_review.txt181.17 KBbaskaran

Comments

doxigo created an issue. See original summary.

baskaran’s picture

baskaran commented
StatusFileSize
new code_review.txt181.17 KB

Hi @doxigo,

Fix the drupal coding standards.

For more information, find the attached document(Code_review.txt)

Thanks,
Baskaran.

baskaran’s picture

baskaran commented
Status: Needs review » Needs work
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

Thank you for applying! I added the Git instructions for users who aren't maintainers of the project.

doxigo’s picture

doxigo commented
Status: Needs work » Needs review

Thank you all guys for your time, I did fix all the Drupal coding standards with its tool, even though some files mentioned in the "CSS" department, are compiled with webpack and shouldn't really be checked with coding standards

Updated all the necessary npm packages if there were any security implications as well

Thank you

doxigo’s picture

doxigo commented

Any updates on this one guys?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Critical
doxigo’s picture

doxigo commented
Issue summary: View changes

Updated the branch

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Priority: Critical » Normal
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

doxigo’s picture

doxigo commented

Thank you so much, appreciate your work

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.