Refactor and expand ActionsFormTest and ConditionsFormTest

Patch #2 has the expanded tests. Some of these will fail, indicating where work is currently required.

• Action rules_send_to will fail with "Expected a list data type for context Send to but got a email data type instead". This is being addressed in #2723259: Allow single-valued data selector input to be passed as an array for 'multiple' context fields
• Condition rules_list_count_is will fail with "InvalidArgumentException: Cannot set a list with a non-array value. in Drupal\Core\TypedData\Plugin\DataType\ItemList->setValue()". This is when the selector button is pressed and also when saving a value using direct input. It will be fixed in #3159876: Set assignment restrictor for two list and data conditions

Failures exactly as expected.

Patch #4 has the failing but required cases commented out, and the non-required List Count test with the button press removed. These are anotated with @todo with the issue number where they can be un-commented.

Good. All green. This will provide a much more solid base for Actions and Conditions changing/fixing/testing. Hopefully this is RTBC?

When committed, I will re-roll the patches on #2723259: Allow single-valued data selector input to be passed as an array for 'multiple' context fields and #3159876: Set assignment restrictor for two list and data conditions to demonstrate how those patches fix these tests. I will also re-roll that latest patch on #2471481: Integrate Typed Data Widgets which uses these tests to check for the correct widget.

Thanks for expanding the comments. Here's an explanation of my further changes:

1. Yes, I have altered the description of the 'selectors' parameter. It specifies which fields need to have the button pressed to change to 'data selection' before the value is filled in, because those values are data selection values. Some of the forms do not need the press as the restrictor is already set to 'selection' so I could not make any inferences by looking at the field value supplied, therefore it was easiest to have a separate argument.
2. I have added a couple more test cases to check both 'direct input' and 'data selection' when the choice is availbale, but I have not checked that every single double case is covered (I can do that later if required)
3. Uncommented the List Count test now that #3159876: Set assignment restrictor for two list and data conditions is done
4. Fixed a couple of places where a necessary empty 'widgets' parameter was missing before the 'selector' parameter. This is not tested in this issue, but would have added confusion in #2471481: Integrate Typed Data Widgets where the modified test does check this. (which will need a re-roll)

Thanks for the commit. I've looked at test data for other rules issues, and I'd remembered that I had used a $data array to hold the test data, instead of returning the values directly. This makes it much easier when developing/testing/debugging because it allows easy testing of just one case, or the testing of all cases except a few. The test data is the same, I have just added a key to the array, and expained this in the comment block.

I hope you can commit this, then I will work on the failing tests in other issues. Thanks.

Spotted a couple of typos. Ignore #10, use #11. Thanks.

not ready for commit yet

To help with testing/debugging I have added an assertion that we do not see our most common error on saving "InvalidArgumentException: Cannot set a list with a non-array value". This helps to show what the fault is, because the phpunit failure will now identify this, instead of just showning "Error Message". This is still the fallback if that exception is not found. I also added more fields to a few of the list tests.

This is ready to commit now. I won't make any more tweaks.

This is RTBC from within this issue. But there will be further changes required as discovered in #2664280-61: Select lists in action & condition configuration forms

@TR would you like me to merge in the small corrections from that issue, so that we have accurate tests now? The random values I added will probably cause problems elsewhere, so I think that would be a good idea to get them fixed here too, but wanted to check with you first.

That's fine. Thanks for the commit.

Unassigning