Remove deprecation and fix constructor args for \Drupal\Core\Installer\Form\SiteConfigureForm

Problem/Motivation

#3157895: Move 'install_time' state update from \Drupal\Core\Installer\Form\SiteConfigureForm to installed_finished() deprecates the State service from \Drupal\Core\Installer\Form\SiteConfigureForm
We're doing some slightly unholy things in the constructor to preserve BC and triggering a deprecation warning.
This issue is about cleaning that up and restoring a clean constructor in D10.

Proposed resolution

• Restore typehints to the final 2 args to \Drupal\Core\Installer\Form\SiteConfigureForm::__construct()
• Remove the trigger_error() in __construct()
• Remove the DeprecatedServicePropertyTrait
• Remove protected $deprecatedProperties
• Remove the @todo pointing here

Remaining tasks

1. Wait for the 10.0.x branch to open.
2. Fix the stuff.
3. Reviews / refinements.
4. RTBC.
5. Commit.

User interface changes

Nope.

API changes

\Drupal\Core\Installer\Form\SiteConfigureForm::__construct() only takes 5 arguments now, just like the CR warned people it would.

Data model changes

Nope.

Release notes snippet

TBD.