Composer.json file should be present in the module so that all the PHP dependencies can be installed during the module installtion.

CommentFileSizeAuthor
#7 3158293-7.patch1.01 KBgaurav.kapoor
#3 3158293-3.patch967 bytessuresh prabhu parkala
#2 Implement_Composer_JSON_3158293.patch844 bytesPooja Ganjage

Comments

GabrielMartinelli created an issue. See original summary.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new Implement_Composer_JSON_3158293.patch844 bytes

Hi,

I am applying patch for creating composer.json file.

Kindly review the patch once.

Thanks

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Active » Needs review
StatusFileSize
new 3158293-3.patch967 bytes

updated file please review.

Pooja Ganjage’s picture

Pooja Ganjage commented
gaurav.kapoor’s picture

gaurav.kapoor commented
Issue tags: +DIACWJuly2020
gaurav.kapoor’s picture

gaurav.kapoor commented
Assigned: Unassigned » gaurav.kapoor
Status: Needs review » Needs work

The patch doesn't apply anymore.

gaurav.kapoor’s picture

gaurav.kapoor commented
Assigned: gaurav.kapoor » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3158293-7.patch1.01 KB
GabrielMartinelli’s picture

GabrielMartinelli commented
Status: Needs review » Reviewed & tested by the community

Looks Good. Thanks!!.

  • gaurav.kapoor authored dbbc068 on 8.x-1.x 
    Issue #3158293 by gaurav.kapoor, Pooja Ganjage, Suresh Prabhu Parkala:...
gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.