Problem/Motivation

twig_init, nyan_cat_init, phptemplate_init are all pointless

Proposed resolution

Call Extension::load() from \Drupal\Core\Theme\ThemeInitialization::loadActiveTheme()

Remaining tasks

Add change record
Improve deprecation notice

User interface changes

None

API changes

Calling THEME_ENGINE_init() is deprecated and will be removed in Drupal 10.

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#8 3158289-2-8.patch2.63 KBalexpott
#8 7-8-interdiff.txt931 bytesalexpott
#7 3158289-2-7.patch2.58 KBalexpott
#7 2-7-interdiff.txt2.02 KBalexpott
#2 3158289-2.patch2.43 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 3158289-2.patch2.43 KB

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

barboza’s picture

barboza commented
Assigned: Unassigned » barboza

I'll review this issue

barboza’s picture

barboza commented
Assigned: barboza » Unassigned
Status: Needs review » Reviewed & tested by the community

The patch looks fine and works as expected for me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2-7-interdiff.txt2.02 KB
new 3158289-2-7.patch2.58 KB

Updating the deprecation message to be for 9.3.0 and adding the CR.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Related issues: +#3246981: Remove nyan_cat_init() and the legacy group and expected deprecation from \Drupal\Tests\system\Functional\Theme\EngineNyanCatTest::testTemplateOverride
StatusFileSize
new 7-8-interdiff.txt931 bytes
new 3158289-2-8.patch2.63 KB

Created the D10 follow-up - #3246981: Remove nyan_cat_init() and the legacy group and expected deprecation from \Drupal\Tests\system\Functional\Theme\EngineNyanCatTest::testTemplateOverride

  • catch committed 9e3837a on 9.4.x 
    Issue #3158289 by alexpott, barboza: Deprecate hook_init for theme...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.4.x and cherry-picked to 9.3.x, thanks!

  • catch committed 3ab6129 on 9.3.x 
    Issue #3158289 by alexpott, barboza: Deprecate hook_init for theme...
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Reviewed & tested by the community » Fixed
andypost’s picture

andypost
he/him
Primary language Russian
commented

Published CR

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.