Problem/Motivation

twig_init, nyan_cat_init, phptemplate_init are all pointless

Proposed resolution

Call Extension::load() from \Drupal\Core\Theme\ThemeInitialization::loadActiveTheme()

Remaining tasks

Add change record
Improve deprecation notice

User interface changes

None

API changes

Calling THEME_ENGINE_init() is deprecated and will be removed in Drupal 10.

Data model changes

None

Release notes snippet

N/a

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
StatusFileSize
new2.43 KB

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

barboza’s picture

Assigned: Unassigned » barboza

I'll review this issue

barboza’s picture

Assigned: barboza » Unassigned
Status: Needs review » Reviewed & tested by the community

The patch looks fine and works as expected for me.

alexpott’s picture

StatusFileSize
new2.02 KB
new2.58 KB

Updating the deprecation message to be for 9.3.0 and adding the CR.

  • catch committed 9e3837a on 9.4.x
    Issue #3158289 by alexpott, barboza: Deprecate hook_init for theme...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.4.x and cherry-picked to 9.3.x, thanks!

  • catch committed 3ab6129 on 9.3.x
    Issue #3158289 by alexpott, barboza: Deprecate hook_init for theme...
voleger’s picture

Status: Reviewed & tested by the community » Fixed
andypost’s picture

Published CR

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.