Fe. the lovely gin admin theme offers dark mode and highlight colors.

We should reduce our css to be more open for admin themes.

Also the browser in the modal overlaps in most of the cases too much, so the user needs to scroll.

CommentFileSizeAuthor
#2 3157716-interfer_less_with_admin_themes-2.patch2.82 KBytsurk

Comments

ytsurk created an issue. See original summary.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Title: Support gin theme modes » Fine tune the browser look and support more themes and their variants
Assigned: ytsurk » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3157716-interfer_less_with_admin_themes-2.patch2.82 KB

Here a patch tested with seven, claro, olivero, bartik (left the dark body background in ..) and gin (with darkmode).

This is fixing:

  • Moves the height calculation away from the wrapper to the borwser-list part
  • The height of the header and footer, by suppressing the buttons margin
  • Tries to respect the themes background by making the gray parts lighter and transparent
  • Makes the jsTree selection a bit less blinky to have more contrast in dark mode
  • Vertically aligns the status message in the footer

  • ytsurk committed 3f01a73 on 2.x 
    Issue #3157716 by ytsurk: Fine tune the browser look and support more...
ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Needs review » Fixed

Nobody seems to be interested to review :(

ytsurk’s picture

ytsurk
Location Switzerland
commented
Version: 8.x-1.x-dev » 2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.