[D8] CKEditor Tweetable Text

Hi @gaurav.kapoor,

I see that phpcs shows few errors.

FILE: /home/lenovo/Public/sri8/modules/tweetext/tweetext.module
---------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------
11 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
12 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
13 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
23 | ERROR | [x] Expected 1 space between double arrow and "Url"; 2 found
23 | ERROR | [x] Expected 1 space after "=>"; 2 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

Time: 1.58 secs; Memory: 8MB

Hi @gaurav.kapoor,

I have reviewed and not found any errors. Also the functionalities are working fine. looks good.

Thanks for your contribution, I haven't seen any security issue related to the code.

manual review:

1. The Git commits are not connected to your user account. You need to specify an email address. See https://www.drupal.org/node/1022156 and https://www.drupal.org/node/1051722
2. getButtons(): do not use base_path() to manually assemble URLs. Use file_create_url() instead.

This module on its own does not contain a lot of code, but given that gaurav.kapoor has lots of commits on other projects and experience with maintaining projects we can do a full promotion here.

Thanks for your contribution, Gaurav!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.