This issue is to track all the changes that needs to be done to ensure an upgrade path:

  • Install the new import config entity
  • Install the new import entity status entity
  • Create a "default" import config, with the appropriate plugins enabled to ensure same behavior as the 8.x-2.x.
  • Entity Share Async:
    • Clear the state and mention that entities will need to be remarked for async import. Or change the state to reference the "default" import config created before.
    • Create a hook_uninstall to delete the state.
  • Entity Share Cron:
    • Remove the url and url_uuid from config. Set the default import config.
    • Set a page_limit of 5 in config.
    • Clear the queue because existing item will not have the appropriate data to be executed
    • Maybe reset the last cron execution state to have stuff queued up as soon as the update is done
  • ...

Prepare a change record:

  • Events removed in favor of plugins with steps to interact with.

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

Issue summary: View changes
grimreaper’s picture

Issue summary: View changes
grimreaper’s picture

Issue summary: View changes
grimreaper’s picture

Issue summary: View changes
grimreaper’s picture

Issue summary: View changes
grimreaper’s picture

Assigned: Unassigned » grimreaper
grimreaper’s picture

Status: Active » Needs review
StatusFileSize
new5.33 KB

This the patch for Entity Share. I will do a dedicated issue for the patch on Entity Share Cron.

Then will need to reinstall my local environment on 8.x-2.x then make the update to test.

Just triggering the tests.

grimreaper’s picture

Status: Needs review » Needs work

As an hook_update_dependencies needs to be done in entity_share_cron to be sure the default import config will be created.

The content of entity_share_client_post_update_create_default_import_config needs to be put in entity_share_client_update_8302.

I will do that tomorrow.

grimreaper’s picture

Finally no need of hook_update_dependencies, because it is only referencing a string in entity_share_cron settings.

So the creation of the default import config can happen after.

grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Needs work » Fixed

Upgrade path ok and merged.

Change record done: https://www.drupal.org/node/3160975

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.