This issue is to track all the changes that needs to be done to ensure an upgrade path:
- Install the new import config entity
- Install the new import entity status entity
- Create a "default" import config, with the appropriate plugins enabled to ensure same behavior as the 8.x-2.x.
- Entity Share Async:
- Clear the state and mention that entities will need to be remarked for async import. Or change the state to reference the "default" import config created before.
- Create a hook_uninstall to delete the state.
- Entity Share Cron:
- Remove the url and url_uuid from config. Set the default import config.
- Set a page_limit of 5 in config.
- Clear the queue because existing item will not have the appropriate data to be executed
- Maybe reset the last cron execution state to have stuff queued up as soon as the update is done
- ...
Prepare a change record:
- Events removed in favor of plugins with steps to interact with.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | entity_share-upgrade_path-3157112-8.patch | 5.33 KB | grimreaper |
Comments
Comment #2
grimreaperComment #3
grimreaperComment #4
grimreaperComment #5
grimreaperComment #6
grimreaperComment #7
grimreaperComment #8
grimreaperThis the patch for Entity Share. I will do a dedicated issue for the patch on Entity Share Cron.
Then will need to reinstall my local environment on 8.x-2.x then make the update to test.
Just triggering the tests.
Comment #9
grimreaperAs an hook_update_dependencies needs to be done in entity_share_cron to be sure the default import config will be created.
The content of entity_share_client_post_update_create_default_import_config needs to be put in entity_share_client_update_8302.
I will do that tomorrow.
Comment #10
grimreaperFinally no need of hook_update_dependencies, because it is only referencing a string in entity_share_cron settings.
So the creation of the default import config can happen after.
Comment #12
grimreaperUpgrade path ok and merged.
Change record done: https://www.drupal.org/node/3160975