CommentFileSizeAuthor
#15 3156977_15.patch666 bytesfernly
#12 3156977_5.patch611 bytespriya.chat
#4 3156977_4.patch638 bytesmpp
#2 3156977_2.patch614 bytesmpp

Issue fork drupal-3156977

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mpp created an issue. See original summary.

mpp’s picture

mpp commented
Status: Active » Needs review
StatusFileSize
new 3156977_2.patch614 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 3156977_2.patch, failed testing. View results

mpp’s picture

mpp commented
Status: Needs work » Needs review
StatusFileSize
new 3156977_4.patch638 bytes
johnwebdev’s picture

johnwebdev commented

What are the steps to reproduce this on a clean install?

mpp’s picture

mpp commented

Hi John, thank you for your comment.

Not really sure what caused this but I got this notice when working with og_menu.

Does it really matter how this is reproduced? Arrays don't have interfaces so it seems like a bad practice to just go ahead without checking a specific index is available. A lot of php logs I've seen are filled with countless of these "no index defined" notices. Imo, either we use an interface or we test if an index exists (can be done with either isset or empty, depending on the need).

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs tests

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Think the fix should be to find out what is causing this to be passed. Fix the route cause vs symptom.

Either way will need a test case.

priya.chat’s picture

priya.chat commented
Status: Needs work » Needs review
StatusFileSize
new 3156977_5.patch611 bytes

Hi all, I have add not empty check that will handle the empty case and also the undefined case. Kindly review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Still needs tests.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

fernly’s picture

fernly commented
StatusFileSize
new 3156977_15.patch666 bytes

Updated latest patch to make it apply to Drupal 11.2.3.
Added no tests in this update.

oily made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +Needs steps to reproduce, +Needs issue summary update

This will need steps to reproduce.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Closing out. If still a bug in D11 please re-open updating the summary with steps to reproduce.

Thanks all

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.