Several functions in the ingredient.module file can be converted to services:

These three should probably go in the same service:

  • ingredient_quantity_from_decimal()
  • ingredient_greatest_common_divisor()
  • ingredient_quantity_from_fraction()

We don't currently use ingredient_unit_fuzzymatch(), but its functionality is really useful for anyone attempting to do recipe imports. So I want to leave it in the module as a service.

CommentFileSizeAuthor
#9 3156825-9.patch24.48 KBdcam
#8 interdiff.txt2.96 KBdcam
#8 3156825-8.patch24.48 KBdcam
#7 interdiff_5-6.txt2.08 KBnitesh624
#7 3156825-6.patch23.94 KBnitesh624
#5 3156825-5.patch23.51 KBnitesh624
#4 3156825-4.patch23.47 KBnitesh624
#3 3156825-3.patch23.47 KBnitesh624

Comments

dcam created an issue. See original summary.

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Assigned: Unassigned » nitesh624
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 3156825-3.patch23.47 KB
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 3156825-4.patch23.47 KB
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 3156825-5.patch23.51 KB
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Assigned: nitesh624 » Unassigned
Status: Active » Needs review
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 3156825-6.patch23.94 KB
new interdiff_5-6.txt2.08 KB

Fix coding standard warning in last patch

dcam’s picture

dcam commented
StatusFileSize
new 3156825-8.patch24.48 KB
new interdiff.txt2.96 KB

Thank you @nitesh624! I'm sorry that I didn't get to this patch sooner. The last few months have been rough for me. I made a few minor changes, mostly just re-adding the old functions and deprecating them rather than removing them entirely.

dcam’s picture

dcam commented
StatusFileSize
new 3156825-9.patch24.48 KB 
+++ b/modules/ingredient/ingredient.module
@@ -239,67 +128,12 @@ function ingredient_quantity_from_fraction($ingredient_quantity) {
+  return \Drupal::service('ingredient.quantity')->getUnitFuzzymatch($subject);

I wrote the wrong service here.

  • dcam committed 7639ab1 on 8.x-2.x 
    Issue #3156825 by nitesh624, dcam: Convert ingredient.module functions...
dcam’s picture

dcam commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.