Closed (fixed)
Project:
Bootstrap Layout Builder
Version:
1.2.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Jul 2020 at 11:24 UTC
Updated:
9 Jul 2020 at 08:12 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
presseyj commentedAgreed, great module, been working around these layout issues and this is great is pretty much exactly what I needed (even the older version was just fine). But... I concur, same issue:
Theme: Bootstrap 8.x-3.23
Drupal Version: 8.9.1
Comment #3
mahmoud-zayed commentedHi guys,
So excited that you like it, I am going to try to reproduce that issue, if you can provide me with the steps to reproduce it would be great:)
Thanks
Mahmoud
Comment #4
mindhunter75 commentedHi Mahmoud-Zayed,
Thank you for your fast reply!
I don't know all the steps because is was a "big website" but i will make a new installation with al the modules and will test when the problem appears. I'll write all the steps down for you and send it to you.
You'll hear from me. Thank you in advance.
Comment #5
julianmancera commentedHi Mahmoud-Zayed,
From what I checked the attached library bootstrap_layout_builder/base is loaded correctly. Both css and js files are loaded in by ajax call. The problem might be related to the css selector called 'blb_ui ' that for some reason is removed by the bootstrap theme:
Without boostrap:
With boostrap
I suggest to add the selector blb_ui in the container.html.twig of the boostrap subtheme to fix.
Additionally, for some reason it also removes the tab selector .blb_nav-tabs so we should change the selector from class selector id selector #blb_nav-tabs in base.css
Another thing that should be do is to disable the modal in bootstrap sub theme configuration.
Let me know yout comments,
Julian Mancera
Comment #6
aaronchristian commentedThank you both for flagging this issue.
We will test some more local installs with the Drupal bootstrap theme and see how we can replicate/fix the issues.
Comment #7
mindhunter75 commentedHi!
Thank you julianmancera for your explanation.
I just made a new installation. Only added the bootstrap_layout_builder module and the bootstrap theme and the problem occurs.
Don't know if this has any value to you after Julian's post, but i've promised that i would make a new installation and test when the problem occurs :)
Comment #8
julianmancera commentedHi all,
I have been working in a patch to fix the problem with style and javascript behaviors it is attach, can you please give it a try? Steps to make it work:
https://www.drupal.org/files/issues/2020-07-06/blb-breaks-with-boostrap-theme-3156391-13732652.patch
Comment #9
mahmoud-zayed commentedHi @julianmancera,
Thanks for your patch, I have checked the issue from a while. And I agree with you using IDs instead of classes is a good solution for this issue. Would you make your update on SCSS files since we are using it to build the CSS styles?
Thanks,
Mahmoud
Comment #10
mahmoud-zayed commentedComment #11
julianmancera commentedHi Mahmoud-Zayed,
Here is the fixed patch. It is good to mention that there is a js fix for the selected breakpoints as the bootstrap template for label differs from the default one.
Regards,
Julian
Comment #12
mindhunter75 commentedThank you Julianmancera for the patch. It workes great :) Well done!
Comment #13
mahmoud-zayed commentedComment #14
aaronchristian commentedReviewing, thanks for the patch julianmancera!
Comment #15
freddy rodriguezPatch #11 works great!
Comment #17
mahmoud-zayed commentedThanks julianmancera for the patch.
Thanks Freddy, Aaron, mindhunter75, presseyj for testing and catching this issue.
I have committed the patch to 1.x with some other code to solve the same issue with Bario bootstrap4 theme. so now the latest commit tested with:
I appreciate if you can test this in the Dev branch, hopefully, we can release a release "1.3" by tomorrow.
Regards,
Mahmoud
Comment #18
mindhunter75 commentedHi Mahmoud-zayed,
Many thanks!
I could not add a section, it was because of this file:
/modules/contrib/bootstrap_layout_builder/templates/row-columns.html.twig
Changing "sameas" to "same as" in this file fixed the problem that i could not add a section.
Now everthing works, except if i upload an image as background, i'm not able to add a section.
(Drupal 9.0.1 / Bootstrap 8.x-3.23)
Comment #19
aaronchristian commentedHey mindhunter75,
Please follow this thread if you are using the latest dev version, the issues is related to the no gutters enhancement.
https://www.drupal.org/node/3157518
Comment #20
mahmoud-zayed commentedAdded to 1.3 Release.
Comment #21
mindhunter75 commentedMany thanks Mahmoud-Zayed for all your work. It's really a great module that makes the layoutbuilder a really good pagebuilder!!!