Problem/Motivation

$result = $connection->query(
      'SELECT name, value FROM {key_value_expire} WHERE collection = :collection',
      [
        ':collection' => $collection,
      ])->fetchAll();

Proposed resolution

$result = $connection->select('key_value_expire', 'kve')
      ->fields('kve', ['name'])
      ->condition('collection', $collection)
      ->execute()
      ->fetchAll();

Remaining tasks

TBD

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

TBD

CommentFileSizeAuthor
#4 interdiff_2-4.txt530 bytesmohrerao
#4 3156188-4.patch990 bytesmohrerao
#2 3156188-2.patch994 byteshardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

Status: Active » Needs review
StatusFileSize
new994 bytes

Kindly review a patch.

Status: Needs review » Needs work

The last submitted patch, 2: 3156188-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mohrerao’s picture

StatusFileSize
new990 bytes
new530 bytes

Fixed CS error.

mohrerao’s picture

Status: Needs work » Needs review
siddhant.bhosale’s picture

Assigned: Unassigned » siddhant.bhosale

Reviewing the issue.

siddhant.bhosale’s picture

Assigned: siddhant.bhosale » Unassigned
Status: Needs review » Reviewed & tested by the community

The patch looks good to me. Also this issue is covered in the patch https://www.drupal.org/project/drupal/issues/3152398.

Requesting to mark it duplicate and close.

hardik_patel_12’s picture

Status: Reviewed & tested by the community » Closed (duplicate)

@siddhant.bhosale thankyou for review ing issues, closing as these is already covered in issue mentioned in #7.