Route migrate process plugin shouldn't assume that the $options variable is always an array

1. +++ b/core/modules/migrate/tests/src/Kernel/process/RouteTest.php
   @@ -25,6 +25,19 @@ class RouteTest extends KernelTestBase {
   +    // We have to set up the system.site since PAthProcessorForn::processInput
   

   🤓 PAth → Path

   🤓 "set up the system.site" does not really make sense I think. It should either be "set up the system.site config" or "configure a front page".

2. +++ b/core/modules/migrate/tests/src/Kernel/process/RouteTest.php
   @@ -48,141 +61,144 @@ public function testRoute($value, $expected) {
   +      // Valid internal link path and options.
   +      'Valid internal link path and options' => [
   ...
   +      // Valid internal link path and empty options.
   +      'Valid internal link path and empty options' => [
   

   👏 for using meaningful labels for test cases of a data provider.

   🙈 … but that means the comment is unnecessary — let's remove it!

3. 🤔 Am I missing something or is there no new test case for now allowing options to not be an array? A failing test-only patch would prove me wrong 🤓

HI @Wim Leers
Updated patch please review.

#6 only pulled out the comments specifically mentioned by @wimleer in #5, but there are several other similar comments among those test cases which should also be removed.

Addressed remaining pointers from #5

Reviewing this and I wish there was a patch with just the new tests that did not include the changes to the array keys. There was just a lot of noise to deal with. I do prefer the string array keys but it was too many changes at one for me.

Anyway, the patch is fine, testing for an array before using a variable as an array is sensible. And the test covers the use case.

+++ b/core/modules/migrate/src/Plugin/migrate/process/Route.php
@@ -127,7 +127,9 @@ public function transform($value, MigrateExecutableInterface $migrate_executable
+        if (is_array($options)) {
+          $route['options'] += $options;
+        }

+++ b/core/modules/migrate/tests/src/Kernel/process/RouteTest.php
@@ -48,141 +61,150 @@ public function testRoute($value, $expected) {
+      'Valid internal link path and non-array options' => [
+        'data' => [
+          'user/login',
+          'options',
+        ],
+        'expected' => [
+          'route_name' => 'user.login',
+          'route_parameters' => [],
+          'options' => [
+            'query' => [],
+          ],
+          'url' => NULL,
         ],

Here we set $options to a string. It feels odd to ignore this data. In the issue summary we say we need this stubbing. What is $route['options'] in this case - is it NULL? Because if so I think the fix should be something like

if ($options) {
  $route['options'] += $options;
}

or maybe the issue is with

    else {
      list($link_path, $options) = $value;
    }

if $value is ['some_path'] ... then $options is going to be NULL.

Maybe the better fix would be

    else {
      list($link_path, $options) = $value;
      $options = (array) $options;
    }

Setting to NW to address the questions in #13

The route process plugin is not specific to Drupal 7 sources, removing tag.

Patch was no longer applying to 11.x so I converted it into an MR with a really small change for it to apply.
Feedback from #13 still needs addressing.