[D8] Announcement Modal

Thank you for applying! I added the Git instructions for non-maintainer users. Reviewers will check the project and post comments to list what should be changed.

Remember to change status, since this issue uses Needs review for telling the reviewers the project is ready to be reviewed.

Hi @akshay_d,

Please check the below review comments.

1. Better to add condition while submitting ""From Date" and "To Date". "From Date" should be a start date. Now i can able to submit like below.
From Date :- 30/07/2020
To Date:- 07/07/2020

2. Typo mistake in the "Uses" description.
3. Popup having some style issues with alignment for the image, title and description.

Hi @akshay_d

Please check the below comments and attached reference screenshots.

1. Not sure it is "use" or "users". Please refer attached screenshot. You can use like the following. [ "Also, this module has a cookie setting like the announcements will be loaded once in a day later users can see the announcements using a sticky widget on the page." ]
2. Better to mention or add some logic if selected both background color and background image. Now disabling the background color , then only we can see the background image. [Note: User can understand which one should be showed]
3. Can't see the full description on the popup. Better to add some restriction on the description field or truncate the content with on demand read more. seems like title and description position is not correct.
4. Can't see the full image in the popup. Better to add some help text with resolution details or please add the image preview with cropping widget over there.
5. can't see the title and description while showing the background image. Also better to add some field for selecting the text color while selecting the light and dark images. So the text is clearly visible on the background image.
5. Better to change the "Show banner" to some other label. It is something related enable/disable the Announcement popup.

Hi @akshay_d,

Better to fix some style alignments. Please refer attached images.

Hi @akshay_d,

Please check the attached image for your reference.

Hi @akshay_d,

I am using MAC with the chrome browser. It is look like different on here. Also please try to upload the background image and check the style alignment over there.
One more defect is here. By default uploading the image through the "managed_file" is temporary. Temporary files might be deleted after some time. So please add code for set the file permanent for uploading the image.

That is something to report in the project issue queue. It could be a bug in the project, but it doesn't seem reproducible.

Anyway, the purpose of these reviews is not finding out every bug in the code and fix them, but verifying what the users who apply understand in writing secure code that follows the Drupal coding standards and correctly uses the Drupal APIs.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.