Problem/Motivation

As title.

Proposed resolution

For example:


- $this->assertTrue(stristr($top_form_elements[0]->getText(), 'Title field is required.') !== FALSE);
+ $this->assertStringContainsString('Title field is required.', $top_form_elements[0]->getText());

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3155761-2.patch968 byteshardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
Status: Active » Needs review
StatusFileSize
new 3155761-2.patch968 bytes

Kindly review a patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Only one instance of stristr() in assertions and this one doesn't look to need to be case insensitive, so this is good to go.

  • catch committed 207fb2b on 9.1.x 
    Issue #3155761 by Hardik_Patel_12, longwave: Replace assertions...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.