Problem/Motivation

There are many misspelled words in the drupal core [9.1.x-dev].
Currently the Drupal dictionary contains words that are misspelt in core at the time we added spellchecking to core. It might be necessary to regenerate the dictionary if misspelt words have been fixed without removing them from the Drupal dictionary.

Proposed resolution

Refer to https://www.drupal.org/node/3122084 follow the steps to regenerate the dictionary and fix the misspelled words.
Make child issues for the same for modules.

Remaining tasks

  1. Fixing the misspelled words.
  2. Regenarating the dictionary.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#23 interdiff-21-23.txt680 bytesmayurjadhav
#23 3155679-23.patch586 bytesmayurjadhav
#21 interdiff_19-21.txt603 bytessuresh prabhu parkala
#21 3155679-21.patch1.89 KBsuresh prabhu parkala
#19 3155679-19.patch1.89 KBhardik_patel_12
#17 3155679-17.patch5.39 KBsiddhant.bhosale
#4 3155679-4.patch26.52 KBsiddhant.bhosale
#2 3154051-3.patch26.52 KBsiddhant.bhosale

Comments

siddhant.bhosale created an issue. See original summary.

siddhant.bhosale’s picture

siddhant.bhosale commented
StatusFileSize
new 3154051-3.patch26.52 KB

Hi, I am uploading the newly regenerated dictionary.

The output after changes is as follows :

$ yarn run spellcheck:core                                                                                                                                                                            
yarn run v1.21.1
$ cspell "**/*" "../composer/**/*"
CSpell: Files checked: 14593, Issues found: 0 in 0 files
✨  Done in 277.26s.
siddhant.bhosale’s picture

siddhant.bhosale commented
Assigned: siddhant.bhosale » Unassigned
Status: Active » Needs review
siddhant.bhosale’s picture

siddhant.bhosale commented
StatusFileSize
new 3155679-4.patch26.52 KB

I have name the patch wrongly. Renaming the patch and uploading.

siddhant.bhosale’s picture

siddhant.bhosale commented
Issue tags: +Bug Smash Initiative
siddhant.bhosale’s picture

siddhant.bhosale commented
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

How did you regenerate the dictionary? We have a yarn command in package.json that will regenerate it, but that also converts all words to lowercase and re-sorts the dictionary, which doesn't seem to have happened here.

Please also see #3155463: Fix spelling error in Drupal\filter\Plugin\migrate\process\FilterID::getSourceFilterType() which fixes the only two issues I know of with the current dictionary.

siddhant.bhosale’s picture

siddhant.bhosale commented

Hi @longwave, I followed this https://www.drupal.org/node/3122084 to regenerate the dictionary. Also I have found 6 words which are missplet in the dictionary as follows :

Alows
Appers
alows
appers
autcomplete
inpur

Please guide me here if I am missing something?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

There are lots of misspelled words in the dictionary, we still need to remove these. For the time being, having the dictionary just means we don't add any new misspelled words.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Ah, the command in https://www.drupal.org/node/3122084 was out of date, thanks for flagging this - I've updated this to show the new command needed to regenerate the dictionary.

siddhant.bhosale’s picture

siddhant.bhosale commented

So does this mean currently we can't even fix the misspelled words in the dictionary ?

siddhant.bhosale’s picture

siddhant.bhosale commented

@longwave thank you for updating the command for regenerating the dictionary. Please let me know if I can fix the misspelled words in the dictionary?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Sure, we need to correct the spelling mistakes too, but that should probably be a different issue if this one is just for regenerating the dictionary.

siddhant.bhosale’s picture

siddhant.bhosale commented
Issue summary: View changes
siddhant.bhosale’s picture

siddhant.bhosale commented
Assigned: Unassigned » siddhant.bhosale
siddhant.bhosale’s picture

siddhant.bhosale commented
Issue summary: View changes
siddhant.bhosale’s picture

siddhant.bhosale commented
StatusFileSize
new 3155679-17.patch5.39 KB

Hi, have fixed a few words which were misspelled in the core. Adding the Patch for the same.

siddhant.bhosale’s picture

siddhant.bhosale commented
Assigned: siddhant.bhosale » Unassigned
hardik_patel_12’s picture

hardik_patel_12 commented
StatusFileSize
new 3155679-19.patch1.89 KB

Re-rolling the patch as last patch failed to applied.

Status: Needs review » Needs work

The last submitted patch, 19: 3155679-19.patch, failed testing. View results

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 3155679-21.patch1.89 KB
new interdiff_19-21.txt603 bytes

Please review the patch.

quietone’s picture

quietone commented
Status: Needs review » Needs work 
+++ b/core/modules/migrate/tests/src/Unit/process/SubstrTest.php
@@ -48,7 +48,7 @@ public function providerTestSubstr() {
-      [1, NULL, 'aptain Janeway'],
+      [0, NULL, 'Captain Janeway'],

This is not a spelling mistake! It is the correct return value in the test. I deliberately wrote this to NOT start at 0.

As I read the issue summary and #13this issue is to generate the dictionary not fix the spelling mistakes.

mayurjadhav’s picture

mayurjadhav commented
Status: Needs work » Needs review
StatusFileSize
new 3155679-23.patch586 bytes
new interdiff-21-23.txt680 bytes

Updated the patch along with inter diff, Kindly review.

Removed following change as it was already resolved in another ticket,

- * - disabled: Whether the inpur is disabled.
+ * - disabled: Whether the input is disabled.
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Closed (outdated)

All misspellings identified in this issue have now been fixed in other issues. This issue was not very well scoped, #3122088: [Meta] Remove spelling errors from dictionary.txt and fix them has further issues to follow up on and I suggest picking a specific subset of misspellings when opening other child issues.