Problem/Motivation

Fox example:

-    $this->assertFalse(in_array('t3', $cids), "Existing key 3 has been removed from &\$cids");
-    $this->assertTrue(in_array('t4', $cids), "Non existing key 4 is still in &\$cids");
+    $this->assertNotContains('t3', $cids);
+    $this->assertContains('t4', $cids);

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 entity_usage_replace_in_array-with-assertContains-3155641.patch825 bytesgena.io

Comments

gena.io created an issue. See original summary.

gena.io’s picture

gena.io commented
StatusFileSize
new entity_usage_replace_in_array-with-assertContains-3155641.patch825 bytes
gena.io’s picture

gena.io commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

looks good to me

  • alexpott committed 9df50ce3 on 8.x-2.x 
    [#3155641] chore: Replace assertions involving calls to in_array() with...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I think this could be further improved because the assert is really odd. But so be it.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.