Problem/Motivation

We're standardising on writable over writeable so we need to change the requirement name in system_requirements().

See #2898947: Change "writeable" to "writable" in documentation

Proposed resolution

Change it.

Remaining tasks

User interface changes

None

API changes

Internal "API" change - the render array for requirements has a different key.

Data model changes

None

Release notes snippet

CommentFileSizeAuthor
#9 Screenshot from 2022-01-18 09-49-12.png23.66 KBvikashsoni
#6 After--patch.jpg27 KBranjith_kumar_k_u
#4 3155400-4.patch646 bytesjungle
#2 3155400-2.patch773 bytesjungle

Comments

alexpott created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Active » Needs review
Related issues: +#3155411: Add "writeable" to the "flagWords" in core/.cspell.json
StatusFileSize
new 3155400-2.patch773 bytes

Changed and added an @todo (filed #3155411: Add "writeable" to the "flagWords" in core/.cspell.json)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Needs work 
+++ b/core/includes/install.core.inc
@@ -2185,7 +2185,9 @@ function install_check_requirements($install_state) {
+        // @todo Add "writeable" to the "flagWords" in core/.cspell.json in
+        //   https://www.drupal.org/node/3155411
+        $requirements["$file file writable"] = [

The follow-up issue is great but I don't think we need an @todo here. This line does not need to change in #3155411: Add "writeable" to the "flagWords" in core/.cspell.json

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs work » Needs review
StatusFileSize
new 3155400-4.patch646 bytes

@alexpott, thanks for reviwing! @todo removed, no interdiff.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new After--patch.jpg27 KB

The patch works as expected.
after patch

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

vikashsoni commented
StatusFileSize
new Screenshot from 2022-01-18 09-49-12.png23.66 KB

Applied patch #4 in drupal-9.3.x-dev applied successfully
After patch ' writeable ' has been updated with ' writable '
Thanks for the patch

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs tests, +Needs change record updates

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

@expectedDeprecation appears to no longer be used in Drupal core so tags for test to replace though.
Change record would have to be updated for deprecated in 10.1 and removed in 11

Thanks

Running d10 test

smustgrave’s picture

smustgrave commented
Issue tags: -Needs tests, -Needs change record updates

Wrong comment as I was reviewing the patch from a linked ticket.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Ran tests for #4 with no issue and fixes a typo.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 12db5f3 and pushed to 10.1.x. Thanks!

  • catch committed 12db5f38 on 10.1.x 
    Issue #3155400 by jungle, alexpott: Change $requirements["$file file...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.