Visibility per language summary

1. +++ b/src/Plugin/paragraphs/Behavior/ParagraphsLanguagePlugin.php
   @@ -182,4 +182,35 @@ class ParagraphsLanguagePlugin extends ParagraphsBehaviorBase {
   +
   +    switch ($visibility['visibility']) {
   +      case 'hide':
   +      case 'show':
   +        $summary[] = [
   +          'label' => $visibility['visibility'] == 'hide' ? 'Hide for' : 'Show for',
   +          'value' => \implode($language_names, ', '),
   +        ];
   

   hide for/show for should be translatable strings.

2. +++ b/src/Plugin/paragraphs/Behavior/ParagraphsLanguagePlugin.php
   @@ -182,4 +182,35 @@ class ParagraphsLanguagePlugin extends ParagraphsBehaviorBase {
   +      case 'always':
   +      case 'default':
   +        $summary[] = [
   +          'label' => $this->t('Visibility'),
   +          'value' => $this->t('Always visible')
   +        ];
   +        break;
   

   we don't need a summary for the default setting, that doesn't add something useful.

   Do he have some UI tests that we could easily extend with an assertion for this?

Hi @Berdir
Updated patch please review.

Hm, looks like the test class renaming in paragraphs broke paragraphs_collection :-/

Lets fix that in a separate issue.

Also, I wasn't clear, but 'always' should be removed as well, not interested in that output either in the summary.

So the existing tests seems to trigger a notice, which is great, because it means we already trigger this method and need to a) fix it and b) add an assert for the expected message.

+++ b/src/Plugin/paragraphs/Behavior/ParagraphsLanguagePlugin.php
@@ -189,14 +189,16 @@
     if ($visibility = $paragraph->getBehaviorSetting($this->getPluginId(), 'container')) {
       if ($visibility['visibility'] == 'hide' || $visibility['visibility'] == 'show') {
-        $language_names = [];
-        foreach ($visibility['languages'] as $language) {
-          $language_names[] = $this->languageManager->getLanguageName($language);
+        if (isset($visibility['languages'])) {
+          $language_names = [];

that we have this extra container key in the stored settings is unfortunate, but hard to fix now.

Committed.