Update from 4.14.0 to 4.14.1.
CKEditor 4.14.1 has been released: https://ckeditor.com/blog/CKEditor-4.14.1-with-resizing-and-toolbar-impr...
I encountered this Bug in Drupal 8.9, and the new release fixes it: https://github.com/ckeditor/ckeditor4/issues/3926
CKEditor has been updated from from 4.14.0 to 4.14.1, which includes numerous bugfixes and improvements.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | interdiff_1_7.txt | 595 bytes | maacl |
| #7 | update-ckeditor-to-version-4-14-7.patch | 1.9 MB | maacl |
| #4 | update-ckeditor-4-14-1--3155110.patch | 590 bytes | MykolaVeryha |
| update-ckeditor-to-version-4-14-1.patch | 1.9 MB | maacl |
Comments
Comment #2
maacl commentedComment #3
nkoporecTested the patch and it works(tested on latest 8.9), it fixes the issue with CKEditor drag, where a JS error would should up:
Comment #4
MykolaVeryha commentedComment #5
MykolaVeryha commentedWe need to add this patch too
It's to clear cache
Comment #6
MykolaVeryha commentedIt works on core 8.8.8
Comment #7
maacl commentedThanks! Updated the patch.
Comment #8
samiullah commentedApplied the patch on clean install of 9.1x
Composer was updated to 4.14.1
This can be moved to RTBC
Comment #9
samiullah commentedComment #10
alexpottI built ckeditor locally and the only difference was a compile timestamp. As this is a bugfix this can go back to 9.0.x. Also I think the same logic applies to 8.9.x - and we should consider committing this there.
Comment #13
wim leers+1
Comment #14
alexpottCherry-picked to 8.9.x as front end framework manager @lauriii +1'd too.
Comment #17
xjmOuch -- this should have been in the 8.9.3 and 9.0.3 release notes. Please always tag any dependency updates that get backported for the release notes.
Comment #18
catchAlso we should probably backport this to 8.8.x
Comment #19
catchOr not - 4.14.0 was a security release, 4.14.1 is not, so we're OK leaving 8.8.x on 4.14.0 for now.
Comment #20
MykolaVeryha commentedCould you write a reason why not? we have a bug with 4.14.0. You can see it above
Why we should not fix the bug? It's not okay to leave bugs.
Comment #21
catch8.8.x only receives security fixes. The bug has been fixed in 9.0.x and 8.9.x and all Drupal 8 sites should be aiming to update to those versions ASAP.
See https://www.drupal.org/core/release-cycle-overview