Closed (fixed)
Project:
Olivero
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 Jun 2020 at 17:47 UTC
Updated:
23 Oct 2020 at 23:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
kostyashupenkoComment #3
kostyashupenkoComment #4
mherchelAt first glance this is a refactor of beauty! I have a couple nitpicks below since we're refactoring the whole thing. I know that most of these are leftovers from the previous code.
Note that I'm still going to do some additional cross browser and device testing. But I don't see anything that looks like it would cause issues.
Thanks!
Some cleanup. We can use e.key === "Escape" here.
Once again, we only need e.key
These variable names seem a bit off to me. The header-nav element wraps all of the navigation (mobile and wide). Maybe just call it "navWrapper"?
We shouldn't use the
js-to indicate that this is processed, the js- prefix is used for selectors that JavaScript will be using. Maybe something like "processed-". Not sure if Drupal has a convention for this type of stuff.Comment #5
mherchelTested both regular and mobile navigation across Chrome, FF, Safari, and IE11. Works great!
Comment #6
kostyashupenkoComment #7
mherchelLooking good!
I'm fixing this on commit!
Comment #9
mherchelCommitted! Thanks!
Comment #10
kostyashupenkoRe-openning, since you forgot to run yarn build:js looks like
Comment #11
mherchelRe-closing since yarn:build has been run, committed, etc.