The IE does not seem to support all "new" JavaScript techniques, so there is a JS error. Unfortunately, this prevents the loading of this module and there is no indication that the browser is out of date. Is it possible that this module is loaded first of all before anything else?

CommentFileSizeAuthor
#4 fix-for-ie11.patch335 bytescpierce42
#2 fix-ie11.patch285 bytescweagans

Issue fork bu-3154405

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    HeavyStoneHead created an issue. See original summary.

    cweagans’s picture

    cweagans
    He/Him
    Primary language English
    Location Boise, ID, USA
    commented
    Status: Active » Needs review
    StatusFileSize
    new fix-ie11.patch285 bytes

    The attached patch changes the order of the bu JS that's added to the page to be after `drupal/core` and `drupal/coreSettings`, but before everything else, thereby allowing the bu JS to run before any new JS syntax cause JS to stop executing.

    This is a somewhat fragile solution (as it will break if the weights are changed in core.libraries.yml), but given that those weights haven't changed since Drupal 8, I'm inclined to think that it's workable for now. The weights for the core JS are hardcoded in core.libraries.yml, so I went with 15 to ensure the correct ordering.

    cpierce42’s picture

    cpierce42
    He/Him/His
    Primary language English
    commented
    Status: Needs review » Needs work

    Pulled down the patch, tested and this patch did not work.

    cpierce42’s picture

    cpierce42
    He/Him/His
    Primary language English
    commented
    Version: 8.x-1.0 » 2.0.1
    Status: Needs work » Needs review
    StatusFileSize
    new fix-for-ie11.patch335 bytes

    This patch fixes the problem for me in IE, loading the JavaScript in the header without manipulating the weights.

    luiscarvalho’s picture

    luiscarvalho commented

    The patch above is likely to work, but if AdvAgg is used and it does not work, you can remove the BU library from preprocess on other module:

    function hook_library_info_alter(&$libraries, $extension) {
  if ($extension == 'bu') {
    $libraries['bu.checker']['js']['js/bu.js']['preprocess'] = FALSE;
  }
}
    cpierce42’s picture

    cpierce42
    He/Him/His
    Primary language English
    commented

    Comment #5 does not fix the problem for me and I am not using AdvAgg module.

    Please review/test #4