#2909426: $modules is now a protected property in tests , Starting with Drupal 9.0.0 this property should now always be protected.

Proposed resolution

Fix definition

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

no

CommentFileSizeAuthor
#2 3153722-2.patch1.87 KBhardik_patel_12

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

hardik_patel_12 commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 3153722-2.patch1.87 KB
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs review » Reviewed & tested by the community

Thanks, @Hardik_Patel_12. It's good to go. A sniff is expected to prevent this from happening again.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Title: Fix test files variable visibility » Make $modules property protected on DuplicateContextualLinksTest, NoMultilingualReviewPageTest and MenuActiveTrail403Test

Changing the title to inline with the changes, or it's too broad.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.1.x-dev » 9.0.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 9a7f4fb and pushed to 9.1.x. Thanks!
Committed ae186bd and pushed to 9.0.x. Thanks!

NoMultilingualReviewPageTest doesn't exist for D7 there but the other two do and have public visibility and need fixing.

  • alexpott committed 9a7f4fb on 9.1.x 
    Issue #3153722 by Hardik_Patel_12: Make $modules property protected on...

  • alexpott committed ae186bd on 9.0.x 
    Issue #3153722 by Hardik_Patel_12: Make $modules property protected on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.