Part of #3116859: [meta] Fix Drupal.Array.Array.LongLineDeclaration coding standard.

CommentFileSizeAuthor
#12 3153701-11.patch47.6 KBsanjayk
#11 3153701-11.patch47.59 KBsanjayk
#4 3153701-4.patch47.83 KBs_bhandari

Comments

daffie created an issue. See original summary.

munish.kumar’s picture

munish.kumar commented
Assigned: Unassigned » munish.kumar
s_bhandari’s picture

s_bhandari commented
Assigned: munish.kumar » s_bhandari
s_bhandari’s picture

s_bhandari commented
Status: Active » Needs review
StatusFileSize
new 3153701-4.patch47.83 KB

I have added a patch for this. Please review the same and let me know for any observation.

s_bhandari’s picture

s_bhandari commented
Assigned: s_bhandari » Unassigned

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

daffie’s picture

daffie commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

The patch does not apply for 9.2.x

anushrikumari’s picture

anushrikumari commented
Assigned: Unassigned » anushrikumari
jonathan1055’s picture

jonathan1055 commented

Hi @anushrikumari,
Before you do too much work on this issue, you may want to postpone it, and wait for the results of discussions on #3173782: Increase line length limit to 120 and on #3116859-20: [meta] Fix Drupal.Array.Array.LongLineDeclaration coding standard from #20 onwards. If the limit is increased then many of the change done in the patches above would not be necessary.
Jonathan

anushrikumari’s picture

anushrikumari commented
Assigned: anushrikumari » Unassigned
sanjayk’s picture

sanjayk commented
Status: Needs work » Needs review
StatusFileSize
new 3153701-11.patch47.59 KB

Re-roll #4 for 9.2

sanjayk’s picture

sanjayk commented
StatusFileSize
new 3153701-11.patch47.6 KB
jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Needs work
Issue tags: -Needs reroll

Thanks sanjayk for the new patch. Just wondering if you saw my comment in #9?

If you do want to proceed, then you need to prove that this change fixes the coding standards. You have to add that standard into the phpcs.xml.dist file, so that it is checked for. The green test pass in #12 does not give any info on whether the coding standard has been fixed by your patch.

Also I suggest you make a temporary change to drupalci.yml so that testing halts after phpcs has run. This will give you quicker results, but more importantly it conserves resources on the server, which currently cost drupal.org $3-4K each month. When all the new coding standard fixes have been made and agreed, then you can do the full test run to include all the phpunit tests, etc.

For examples of both of these requirements, see this patch from #3185652-2: Fix 'Drupal.Commenting.DocComment.ShortFullStop' coding standard - part 2

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Needs work » Closed (duplicate)

This is being done in other sibling issues. I am closing this as a duplicate.