Today I updated Drupal from version 8.8.5 to 8.9.1 and entity sorting in a table stopped working.
I got js error Uncaught ReferenceError: Sortable is not defined in console when the page loaded in the backoffice.
This seems to be due to replacing the jQuery UI Sortable with new SortableJS library from the core as indicated in the related issues.

CommentFileSizeAuthor
#4 3153619-entity-browser-table-custom.patch1.91 KBnightlife2008
#2 sortable_is_not_defined-3153619-2.patch1.07 KBjakoloborodun

Issue fork entity_browser_table-3153619

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jakoloborodun created an issue. See original summary.

jakoloborodun’s picture

jakoloborodun commented
StatusFileSize
new sortable_is_not_defined-3153619-2.patch1.07 KB

- Injected the Sortable dependency
- Added the core/sortable library as a dependency

jakoloborodun’s picture

jakoloborodun commented
Status: Active » Needs review
nightlife2008’s picture

nightlife2008 commented
StatusFileSize
new 3153619-entity-browser-table-custom.patch1.91 KB

Thanks for the patch but this resulted in a new console error stating that "document.queryselector() is null".

I refactored this patch and updated the EntitybrowserTable's behavior accordingly.

Greets,
Kim

botanic_spark’s picture

botanic_spark commented

After applying patch #4 sorting is working again.

botanic_spark’s picture

botanic_spark commented
Status: Needs review » Reviewed & tested by the community

james hawthorn-byng’s picture

james hawthorn-byng commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contributions.
The latest patch has been merged with issue #3166733 into the dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Carlos Romero made their first commit to this issue’s fork.

narendra.rajwar27 changed the visibility of the branch 3153619-sortable-is-not to hidden.

narendra.rajwar27 changed the visibility of the branch 3153619-sortable-is-not to hidden.

narendra.rajwar27 changed the visibility of the branch 3153619-sortable-is-not to active.