Problem/Motivation

We are getting this error for the instances of pager_get_query_parameters usage:


 Call to deprecated function pager_get_query_parameters().
                    Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0.
                    Use
                    \Drupal\Core\Pager\RequestPagerInterface->getQueryParameters
                    () instead.

However, Drupal\Core\Pager\RequestPagerInterface is not an interface available in core. It's been renamed as Drupal\Core\Pager\PagerParametersInterface see https://www.drupal.org/node/2779457 for more details.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3153565-2.patch3.98 KBvijaycs85

Comments

vijaycs85 created an issue. See original summary.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Title: Update deprecation message of pager_get_query_parameters » Update instances of Drupal\Core\Pager\RequestPagerInterface with Drupal\Core\Pager\PagerParametersInterface
Status: Active » Needs review
StatusFileSize
new 3153565-2.patch3.98 KB

Initial patch

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs review » Reviewed & tested by the community

Good catch!

  • catch committed b499870 on 8.9.x 
    Issue #3153565 by vijaycs85: Update instances of Drupal\Core\Pager\...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs reroll

Committed b499870 and pushed to 8.9.x. Thanks!

hardik_patel_12’s picture

hardik_patel_12 commented
Issue tags: -Needs reroll

Patch is failed to apply on 9.1.x because of 

error: core/includes/pager.inc: No such file or directory
error: core/modules/system/tests/src/Kernel/Pager/PagerDeprecationTest.php: No such file or directory

and both files are not exists in 9.1.x branch.

catch’s picture

catch
he/him
Primary language English
commented

Oops I tagged it before realising why that was wrong as explained in #6, but forgot to untag when I did the commit etc., thanks for untagging :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.