Remove uses of t() in linkExists() and linkNotExists() calls

Here is an updated patch.

Hi, I found changes left in files. eg.
core/modules/comment/tests/src/Functional/CommentLinksAlterTest.php has the t() used.
$this->assertSession()->linkExists(t('Report'));. Marking this to needs works.

Hi, I have made the changes. Adding the patch and interdiff as well.

Applied the patch. Then ran grep -r '\->\(linkExists\|linkNotExists\)(t(' core | nl and 11 more instances were found.

Removing the remaining t() calls. Please review.

Fixing failed test cases.

@ridhimaabrol24 some bit of code still has t() after applying ur patch

sami@Samis-MacBook-Air drupal % git grep '\->\(linkExists\|linkNotExists\)(t('
core/modules/book/tests/src/Functional/BookTest.php:    $this->assertSession()->linkNotExists(t('Book outline'), 'Book Author is not allowed to outline');
core/modules/book/tests/src/Functional/BookTest.php:    $this->assertSession()->linkNotExists(t('Remove from book outline'));

Hi @samiullah
By applying patch #18 there are no instances left of linkExists(t( and linkNotExists(t(
Please recheck the same.
Also the code you are referring to in #19 is already present in the patch.
Let me know if you still find issues.
Thanks

I applied that patch and found no usages of t() in lines using linkNotExists or linkExists.

+++ b/core/modules/config_translation/tests/src/Functional/ConfigTranslationOverviewTest.php
@@ -126,7 +126,7 @@ public function testMapperListPage() {
+      $this->assertSession()->linkExists('Translate test configuration');

+++ b/core/modules/config_translation/tests/src/Functional/ConfigTranslationUiTest.php
@@ -299,7 +299,7 @@ public function testSourceValueDuplicateSave() {
+    $this->assertSession()->linkNotExists('Edit');

@@ -331,7 +331,7 @@ public function testContactConfigEntityTranslation() {
+    $this->assertSession()->linkExists('Translate contact form');

@@ -339,7 +339,7 @@ public function testContactConfigEntityTranslation() {
+      $this->assertSession()->linkExists('Translate contact form');

@@ -516,10 +516,10 @@ public function testAccountSettingsConfigurationTranslation() {
+    $this->assertSession()->linkExists('Translate account settings');
...
+    $this->assertSession()->linkExists('Translate account settings');

+++ b/core/modules/menu_link_content/tests/src/Functional/MenuLinkContentTranslationUITest.php
@@ -73,7 +73,7 @@ protected function createEntity($values, $langcode, $bundle_name = NULL) {
+    $this->assertSession()->linkNotExists('Translate');

However, all of these are in tests related to translations. Are we sure the t() should be removed in all these cases? I don't know and I haven't looked at the tests myself.

Patch needs re-roll.

Hello @all,

Patch #25 looks good. I did not find any linkExists() and linkNotExists() with a t() inside.

About comment #23, is okay to remove it because it is testing if the link with the specified label exists or not. So it makes no sense to remove it.
See https://www.drupal.org/docs/automated-testing/phpunit-in-drupal/phpunit-browser-test-tutorial#t

Set to RTBC.

Cheers, Paulo.

Random fail, back to RTBC.

Committed 4a7c205 and pushed to 9.1.x. Thanks!

Looks good now @catch