CommentFileSizeAuthor
#6 3152773.patch1.54 KBtdnshah
#5 Edit_Article_Testing_CKEditor_Allowed_Module_Content_Rules_D8_Contribution.png140.83 KBtdnshah
#5 Edit_Article_Testing_CKEditor_Allowed_7Module_Content_Rules_D8_Contribution.png37 KBtdnshah
#3 Desktop_screenshot.png268.15 KBtdnshah
#3 Desktop_screenshot.png259.64 KBtdnshah
#2 3152773-2.patch2.77 KBbunty badgujar

Comments

Bunty Badgujar created an issue. See original summary.

bunty badgujar’s picture

bunty badgujar commented
Assigned: bunty badgujar » Unassigned
Status: Active » Needs review
StatusFileSize
new 3152773-2.patch2.77 KB

Combine all regular expression in one.

tdnshah’s picture

tdnshah commented
Status: Needs review » Needs work
StatusFileSize
new Desktop_screenshot.png259.64 KB
new Desktop_screenshot.png268.15 KB

@bunty this module is failing the test images attached below are the steps taken for the test.

1. Installed & Enabled ckeditor_acr module.
2. In the ckeditor setting at the location admin/config/content/formats/manage/full_html?destination=/admin/config/content/formats and added the rules as mentioned in the module description page.
3. Created a new article with a "a" tag which do not have a href tag and the article got saved without an "href" attribute.

Images attached.

bunty badgujar’s picture

bunty badgujar commented

@tejas, I can see you added rules in full_html. Can you confirm if you add link in full_html in node or basic_html. Because default is basic_html in node/add form.

tdnshah’s picture

tdnshah commented
StatusFileSize
new Edit_Article_Testing_CKEditor_Allowed_7Module_Content_Rules_D8_Contribution.png37 KB
new Edit_Article_Testing_CKEditor_Allowed_Module_Content_Rules_D8_Contribution.png140.83 KB

@bunty yeah i confirm that i used the Full_html in the editor as well as was aware that i have added rules in Full_html :), but i have a observation here as after adding the a tag without href and saving upon reopening i could see that a tagand its content are wrapped in an p tag

I have attached the image for the same.

Thank you

tdnshah’s picture

tdnshah commented
Issue summary: View changes
StatusFileSize
new 3152773.patch1.54 KB

Adding a note in the description of the setting field stating the prerequisite for this setting to take effect.

bunty badgujar’s picture

bunty badgujar commented
Status: Needs work » Fixed

Thanks @tejas.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.