<nav id="toolbar-bar" role="navigation" aria-label="Toolbar items" class="toolbar-bar clearfix" data-offset-top="" style="">
  <h2 class="visually-hidden" style="transition: none 0s ease 0s;">Toolbar items</h2>
  <div class="home-toolbar-tab toolbar-tab" style="">
    <div class="hidden contextual-toolbar-tab toolbar-tab" style="">
      <button class="toolbar-icon toolbar-icon-edit toolbar-item" aria-pressed="false" type="button" style="transition: none 0s ease 0s;">Edit</button>
      <div style="">
        <nav class="toolbar-lining clearfix" role="navigation" style=""></nav>
      </div>
    </div>
  </div>
</nav>

There are a few issues with the above markup produced by Toolbar module.

  1. Aria label "Toolbar items" duplicates h2 heading.
  2. Empty style attributes
  3. Nested nav element without heading, aria-label and content.
CommentFileSizeAuthor
#9 Screen Shot 2022-07-18 at 5.33.03 PM.png147 KBsmustgrave

Comments

chi’s picture

chi commented

Template: https://github.com/drupal/drupal/blob/9.0.1/core/modules/toolbar/templat...

mohit.bansal623’s picture

mohit.bansal623 commented
Assigned: Unassigned » mohit.bansal623
NitinLama’s picture

NitinLama commented

Works fine, I can't find duplicate h2 heading.
Can you share steps to reproduce this issue.

Version: 9.0.x-dev » 9.1.x-dev

Drupal 9.0.10 was released on December 3, 2020 and is the final full bugfix release for the Drupal 9.0.x series. Drupal 9.0.x will not receive any further development aside from security fixes. Sites should update to Drupal 9.1.0 to continue receiving regular bugfixes.

Drupal-9-only bug reports should be targeted for the 9.1.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.2.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mohit.bansal623’s picture

mohit.bansal623 commented
Assigned: mohit.bansal623 » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3189519: Avoid using H2 in the menu, +#2045039: Cleanup HTML heading structure

#3189519: Avoid using H2 in the menu
#2045039: Cleanup HTML heading structure

Version: 9.1.x-dev » 9.3.x-dev

Drupal 9.1.10 (June 4, 2021) and Drupal 9.2.10 (November 24, 2021) were the last bugfix releases of those minor version series. Drupal 9 bug reports should be targeted for the 9.3.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Active » Closed (cannot reproduce)
Issue tags: +Bug Smash Initiative
StatusFileSize
new Screen Shot 2022-07-18 at 5.33.03 PM.png147 KB

Closing as can't reproduce. I tested on a fresh Drupal 9.5 install and using the ANDI tool did not see duplicate H2s

If you still feel this is an issue please reopen with updated steps.