Add aligment classes to wp-block-drupalmedia-drupal-media-entity for alignment settings support.

I provide a patch that update the rendered element & add the aligment css class

@todo : provide a default css support

CommentFileSizeAuthor
#2 wp-block-drupalmedia-drupal-media-entity-aligment-3152526-2.patch1.77 KBgurvan

Issue fork gutenberg-3152526

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gurvan created an issue. See original summary.

gurvan’s picture

gurvan commented
StatusFileSize
new wp-block-drupalmedia-drupal-media-entity-aligment-3152526-2.patch1.77 KB
henrikakselsen’s picture

henrikakselsen commented
Assigned: Unassigned » roborn
Category: Bug report » Feature request
Status: Active » Needs review

Assigning this to @rob for review.

I don't understand the motivation here though. What do you mean by "alignment settings support." @gurvan.

marcofernandes’s picture

marcofernandes commented
Assigned: roborn » Unassigned
Status: Needs review » Needs work

@Gurvan This patch can't be applied to current code. The media entity filter was removed and now it's rendered by the dynamic blocks processor.
Check gutenberg.theme.inc and gutenberg-block--drupalmedia--drupal-media-entity.html.twig

  • marcofernandes committed 2edb8a1 on 8.x-2.x 
    Issue #3152526 by gurvan, marcofernandes: Support wp-block-drupalmedia-...
marcofernandes’s picture

marcofernandes commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

codebymikey made their first commit to this issue’s fork.

codebymikey opened merge request !6

codebymikey’s picture

codebymikey commented
Status: Closed (fixed) » Needs review

Updated the fix to use a preprocess hook, awaiting code review before merging.

marcofernandes’s picture

marcofernandes commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.