The migration of search.settings configuration (d7_search_settings) assumes that the search_default_module variable is always set. Based on the most recent Drupal 7 codebase, this is false. I guess that it is only set if the admin/config/search/settings form was submitted.
I think that since the Drupal 7 default value is node, Drupal core has to provide a default value node_search here.
variables_required to variables_no_row_if_missing after #3182891: The variables_required setting is a tricky name (Novice)| Comment | File | Size | Author |
|---|---|---|---|
| #3 | core-search_settings_migration-3151993-3.patch | 461 bytes | huzooka |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !50
Comments
Comment #2
huzookaComment #3
huzookaComment #4
huzookaComment #6
wim leers#3152789: Add required variables config to Variable migrate source plugin, and if one of those are missing, return zero rows landed a month ago — no blockers left for this! Been using this for months and it works great 👍
Comment #7
benjifisherI do not know why the testbot did not set the status to NW with the failing test.
Just a guess based on the previous comment: this issue may need an update after #3182891: The variables_required setting is a tricky name.
Comment #8
benjifisherA quick look at the patch confirms my guess. This update looks like a Novice task, so I am adding the tag and updating the "Remaining tasks" in the issue summary.
Comment #9
wim leersCorrect :) Thanks for adding the tag!
Comment #10
anmolgoyal74 commentedComment #11
benjifisher@anmolgoyal74:
Thanks for updating a patch!
We now have the option of using merge requests (MRs). Look for the green "Create issue fork" button. But if you continu using the old patch-based approach, then please attach an interdiff along with the patch. See Creating an interdiff.
Comment #13
benjifisher@anmolgoyal74:
I should have suggested that a Novice task like this is a good time to try something new, like creating a MR, but it looks as though you did not need that nudge.
It seems that creating a MR does not automatically set the issue status to NR. That may change, but for now, please check that when you create a new MR.
Back to RTBC based on #6.
Comment #15
quietone commentedThe testbot is retesting the patch in #10 which fails and then sets the status to NW. Asked in #contribute and if I understand correctly, the thing to do is remove the patch from the display. So, this removes the patch from display and resets the status to RTBC for the MR in #12.
Comment #16
alexpottCommitted and pushed 989fdedc77 to 9.2.x and aec49c3e7c to 9.1.x. Thanks!