After add new item on contruct the tests are failed: https://www.drupal.org/pift-ci-job/1725379

CommentFileSizeAuthor
#6 Img.png34.41 KBrenatog

Comments

RenatoG created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Category: Task » Support request

I think this issue was fixed in #3151812: Dependency Injection duplicated

Valeu Renatão!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Active » Fixed
renatog’s picture

renatog commented

Thanks a lot, Thalles!

But Modal Page tests still failing

https://www.drupal.org/pift-ci-job/1725566

renatog’s picture

renatog commented
Status: Fixed » Needs work
renatog’s picture

renatog commented
Issue summary: View changes
StatusFileSize
new Img.png34.41 KB

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Sorry!
I will review again...

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Thanks Renatão, the issue was a call to dd() function that I forget in ModalPage.php, the tests are ok

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Fixed
renatog’s picture

renatog commented

Amazing!

Good job! Thank you so much, Thalles

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.