t() calls should be avoided in classes

#3 error: corrupt patch at line 53

Rerolled patch #3 for the 9.0.x branch, please review it.

I have added string translation trait and fixed drupal coding standard issues

I'll review this patch.

I've reviewed the #8 patch but after applying the patch below errors are shown:

FILE: /home/drupal/myproject/date_range_formatter/date_range_formatter.install
------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------
 13 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
------------------------------------------------------------


FILE: /home/drupal/myproject/date_range_formatter/date_range_formatter.module
------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------
 3 | ERROR | Missing short description in doc comment
------------------------------------------------------------


FILE: /home/drupal/myproject/date_range_formatter/src/Plugin/Field/FieldFormatter/DateRangeFormatterRangeFormatter.php
------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------
 82 | WARNING | Only string literals should be passed to t() where possible
 93 | WARNING | Line exceeds 80 characters; contains 86 characters
 95 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 95 | WARNING | Only string literals should be passed to t() where possible
------------------------------------------------------------


FILE: /home/drupal/myproject/date_range_formatter/date_range_formatter.info.yml
------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------
 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
------------------------------------------------------------

I have created a patch to fix this issue. Kindly review the patch

Thanks!

The provided patches falls outside the scope of this issue, which should focus only on solving the 't' calls.
Also, on the last patch, the call to a translation method was removed altogether (line 111).

-          $elements[$delta] = ['#markup' => \Drupal::service('date.formatter')->format($start_date, 'custom', t($single_format))];
+          $elements[$delta] = ['#markup' => \Drupal::service('date.formatter')->format($start_date, 'custom', ($single_format))];

The issue scope can be updated by a mantainer, or by the reporter, but for now, I'll review the last patch containing only corrections to t calls.

I had to reroll the #7 patch to commit 8808a9c, and I've corrected more t calls violations.

Please, ignore patch #12, there were some lines of code I added back from a previous commit.

I will review it.

I revised the patch and the t() function usage warnings were fixed.
Moving it to RTBC.