Add core_version_requirement: ^8 || ^9 to lupus_ce_renderer.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.Export as HTMLExport as ASCII

CommentFileSizeAuthor
#5 lupus_ce_renderer-d9_compatibility-3151711-5.patch2.18 KBmostepaniukvm
#2 3151711-2.patch396 byteskarishmaamin

Comments

karishmaamin created an issue. See original summary.

karishmaamin’s picture

karishmaamin commented
StatusFileSize
new 3151711-2.patch396 bytes
suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Active » Needs review
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

without verifying this is actually true, this use useless / dangerous.
Also this should consider #3147976: Automated Drupal 9 compatibility fixes

mostepaniukvm’s picture

mostepaniukvm
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new lupus_ce_renderer-d9_compatibility-3151711-5.patch2.18 KB

checked related #3147976: Automated Drupal 9 compatibility fixes and run drupal-rector on latest dev

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Reviewed & tested by the community

thx, I've checked this and compared it with the bot output - it's matching. So I think this is safe and good to move, let's mark it compatible and do more testing.

  • fago committed d8ac8b0 on 8.x-1.x authored by mostepaniukvm 
    Issue #3151711 by karishmaamin, mostepaniukvm: Drupal 9 compatibility
fago’s picture

fago
Primary language German
Location Vienna
commented

Committed this. Anyway, I'm leaving this open for now until we've done more testing with Drupal 9.

  • mostepaniukvm committed ece55c2 on 8.x-1.x 
    Issue #3151711 by karishmaamin, mostepaniukvm, fago: Drupal 9...

  • mostepaniukvm committed 3070e80 on 8.x-1.x 
    Issue #3151711 by mostepaniukvm: Keep d8 backwards compatibility
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Reviewed & tested by the community » Fixed

I think we can call this fixed, works all fine in my tests.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.