Closed (fixed)
Project:
Drupal core
Version:
9.1.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Jun 2020 at 08:12 UTC
Updated:
18 Aug 2020 at 08:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexpottComment #3
dwwComment #4
alexpottI think we need a change record for this. Fortunately it does not appear that anyone has extended this but it has been copied in contrib - http://grep.xnddx.ru/search?text=%24blacklistFunctions&filename=
Comment #5
dwwCR for each of these separately, or should we do a single CR for all such protected member renaming that's happening under #2993575: [meta] Remove usage of "blacklist", "whitelist", use better terms instead?
Comment #6
alexpottI think one CR per change. There are different concepts. The important thing about the CR is to make anyone who has extended the Error class in custom code to check. That's easier when the CR title has the class in.
Comment #7
dwwHow's this?
The Drupal\Core\Utility\Error::$blacklistFunctions protected member is now called $ignoredFunctions
Comment #8
alexpottThe CR looks great.
Comment #9
jungleNot sure if we need BC for the property
$blacklistFunctions, as no classes in contributed modules has extended it pointed by @alexpott in #3, maybe, the CR is enough. BTW, found$blacklistFunctionsoccurrences in the tag1quo module (http://grep.xnddx.ru/search?text=%24blacklistFunctions&filename=) , but the code is irrelevant to the class \Drupal\Core\Utility\Error.blacklisted/black listed functions -> ignored functions, makes sense to me.
blacklist functions -> ignored functions, not 100% sure. However, @dww is a native English speaker, this change should be good.
Thanks!
Comment #10
alexpottCommitted 5f61f0f and pushed to 9.1.x. Thanks!