Comments

rahulrasgon created an issue. See original summary.

rahulrasgon’s picture

Title: Allow HTML to render through iframe. » Update README.txt
Component: Code » Documentation
meena.bisht’s picture

Assigned: Unassigned » meena.bisht
Status: Active » Needs work
meena.bisht’s picture

meena.bisht’s picture

Issue summary: View changes
StatusFileSize
new1.58 KB
meena.bisht’s picture

Assigned: meena.bisht » Unassigned
meena.bisht’s picture

Status: Needs work » Needs review
dipakmdhrm’s picture

Status: Needs review » Reviewed & tested by the community

Looks good enough.

rahulrasgon’s picture

Status: Reviewed & tested by the community » Needs work
TODO
----

- add more extension like jpg , jpeg , png , pdf etc .
- integrate iframes to render the file data which is loaded in this field .

@meena.bisht Can you update the extensions correctly. Extensions should be rar, tar.gz etc

Thanks

deepak goyal’s picture

Assigned: Unassigned » deepak goyal
deepak goyal’s picture

Assigned: deepak goyal » Unassigned
Status: Needs work » Needs review

Hi @rahulrasgon
Updated patch please review.

deepak goyal’s picture

StatusFileSize
new1.56 KB
new609 bytes
meena.bisht’s picture

Assigned: Unassigned » meena.bisht
Status: Needs review » Needs work

Some minor changes need to be done :
-add more extension like jpg, jpeg, png, pdf, etc.
- integrate iframes to render the file data which is loaded in this field.

The first letter should be capital and adding some extra information to it.

meena.bisht’s picture

Assigned: meena.bisht » Unassigned
Status: Needs work » Needs review
StatusFileSize
new1.66 KB
new1.25 KB

Please find the patch attached with all the updates.

meena.bisht’s picture

Assigned: Unassigned » meena.bisht
StatusFileSize
new1.66 KB
new1.26 KB

Removed extra spacing

Lal_’s picture

Status: Needs review » Needs work
+++ b/README.txt
@@ -1 +1,68 @@
+The module has no menu settings. For this add new field in any of the content-type,

Seems confusing could you rephrase

deepak goyal’s picture

Assigned: meena.bisht » Unassigned
Status: Needs work » Needs review
StatusFileSize
new1.68 KB
new494 bytes

Hi @Lal_
Updated patch please review.

Lal_’s picture

Status: Needs review » Reviewed & tested by the community

Much better moving to RTBC

rahulrasgon’s picture

Status: Reviewed & tested by the community » Fixed

Thank you everyone for working on this issue.

Patch #17 committed and pushed to 1.0.x branch.

Thanks

rahulrasgon’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.