Follow-up to:
- #3150318: Support image fields in RSS enclosure formatter
- #666412: Regression: RSS feed enclosure support lost from core.

In #666412, the file field received a new field formatter, which created an <enclosure/> element for RSS feeds. This was then tested by checking for the XML element in the raw content of /rss.xml.

In #88183: Relative URLs in feeds should be converted to absolute ones this check was converted into a CSS selector, and in #2870448: Convert web tests to browser tests for file module into an XPath query.

Unfortunately, that last part was done incorrectly; this assertion currently can't fail.

See #3150318-6: Support image fields in RSS enclosure formatter for a more detailed description.

CommentFileSizeAuthor
#2 3150661-2.patch1.2 KBcburschka

Comments

cburschka created an issue. See original summary.

cburschka’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new1.2 KB
cburschka’s picture

Assigned: cburschka » Unassigned
james.williams’s picture

Status: Needs review » Reviewed & tested by the community

This all looks good to me.

alexpott’s picture

Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 6b769d1e4f to 9.1.x and 5ecde1b576 to 9.0.x and 83f07ce091 to 8.9.x. Thanks!

Nice find.

Backported to 8.9.x since this is a test fix.

  • alexpott committed 6b769d1 on 9.1.x
    Issue #3150661 by cburschka: FileFieldRSSContentTest uses XPath...

  • alexpott committed 5ecde1b on 9.0.x
    Issue #3150661 by cburschka: FileFieldRSSContentTest uses XPath...

  • alexpott committed 83f07ce on 8.9.x
    Issue #3150661 by cburschka: FileFieldRSSContentTest uses XPath...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.