Closed (fixed)
Project:
Lupus Custom Elements Renderer
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Jun 2020 at 11:50 UTC
Updated:
28 Jul 2021 at 09:44 UTC
Jump to comment: Most recent
Comments
Comment #2
fagoComment #6
mostepaniukvm@golubovicm looks very good in general and works well as basic test coverage.
I left few minor remarks, could you take a look please?
Comment #8
mostepaniukvmThanks @golubovicm looks good now, I merged this PR with only LupusCeRendererAccessTest.php
Now you can add another file in a separate PR and let's continue
Comment #11
fagoSince a basic test was merged, let's set this to done and make follow-ups for all the cases not yet done.