Remove compatibility with unsupported Drupal 8.7

I'm changing the title to make this a general issue for Drupal 9 readiness and I'm updating the priority to critical since every site with config_split installed can not update to Drupal 9 right now.

At the same time I'm offering to co-maintain config_split. All I'd need would be push and release access.

Ah look, this issue has already been fixed in the latest dev. 😅

Closing it for now.

Still offering my co-maintainership. 💙

Ah uh, sorry. Too fast browsing today. This issue is about removing just the core key. I'm sorry!

Well, Drupal core versions before 8.7.7 do not recognize the core_version_requirement key. Removing the core key would make this module incompatible with older installs. See the change record on New 'core_version_requirement' key in info.yml files for modules, themes and profiles allows Composer semantic version constraints including specifying multiple major versions of core.

I'd vote for "won't fix" to be honest.

Oh really? Wow! Yeah, this sounds like a good idea then to maybe open a new 8.x-2.x branch with having the core key removed from the info file and the core_version_requirement set to core_version_requirement: ^8.8 || ^9.

(I think 9.x-* branches are forbidden.)

Setting it to needs work to parallelly adjust the core_version_requirement key as mentioned above and in the linked change record above.

Updated patch as per the changes suggested in #10, please review.

@bircher,
Is 2.0.x only dedicated for the D9 or D8.8 & D9 both ?

RE #13 The policy is to support all supported versions of Drupal core that are possible. So 2.x of config_split will also be for Drupal 8.8 and 8.9. (or Drupal 9 and 10 depending on when 2.x will have its release)

RE #8 That is very surprising given that the change notice https://www.drupal.org/node/3070687 explicitly gives an example for how to support all versions of Drupal 8 and 9 and we have it as in the example.

Given that 8.7 is no longer a supported version we should also remove all other things that make config split compatible with 8.7 so in particular #3042682-18: Drupal 9 Deprecated Code Report So we can keep our code clean.

There's an error on the code that I fixed on the next patch:

Configuration Split
Scanned on Tue, 06/30/2020 - 21:05.

1 error found.

web/modules/contrib/config_split/src/Plugin/ConfigFilter/SplitFilter.php:
┌─────────┬──────┬────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├─────────┼──────┼────────────────────────────────────────────────────────────┤
│ Fix now │ 418 │ Call to deprecated method htaccessLines() of class │
│ │ │ Drupal\Component\PhpStorage\FileStorage. Deprecated in │
│ │ │ drupal:8.8.0 and is removed from drupal:9.0.0. Instead use │
│ │ │ \Drupal\Component\FileSecurity\FileSecurity. │
│ │ │ │
└─────────┴──────┴────────────────────────────────────────────────────────────┘

The latest submitted patch is missing the adjustments to the info file.

Also needs work because simply applying an automatically generated patch will not cut it.
Just look at the few lines surrounding it.. I mean you can see it (although barely) even just looking at the patch alone. You see the duplicated code?
The line of code you are changing in #15 was put there deliberately to support Drupal 8.7 while at the same time support Drupal 9.
If we don't support Drupal 8.7 we can remove the if statement altogether.
And as #16 alludes to, we can remove the core key.

I think I got everything discussed in this issue.

Looks good and tested locally.

Thanks you for your contributions!