We currently rely on the user knowledge and experience with various possible codebase directories structure supported in Drupal 8 and Drupal 9, but we could make it easier for everyone by auto-detecting the correct platform root both for initial setup and cleanup on platform delete task. Patches will follow shortly, since we are using it in BOA for a long time already.

Comments

memtkmcc created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Issue tags: +Drupal 9 compatibility

  • memtkmcc committed 3ba4802 on 7.x-3.x 
    Issue #3149998: Auto-detect Drupal 8 and 9 codebase structure (Apache)
  • memtkmcc committed 3de1a9e on 7.x-3.x
    Issue #3149998: Auto-detect Drupal 8 and 9 codebase structure

  • memtkmcc committed 3ba4802 on 7.x-4.x 
    Issue #3149998: Auto-detect Drupal 8 and 9 codebase structure (Apache)
  • memtkmcc committed 3de1a9e on 7.x-4.x
    Issue #3149998: Auto-detect Drupal 8 and 9 codebase structure
jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Priority: Normal » Major
Status: Active » Needs work

Committing a change like this without review shouldn't have happened.

It screwed up the work I've already done on composer support. It also adds a ton of tech debt... why add the same code to a dozen files? There are hooks to alter template variables or at the place where the root property is actually generated.

I'm moving forward on the 4.x branch to iron out these issues, completing native git and composer support.

  • Jon Pugh committed 6743834 on 7.x-4.x 
    Revert "Issue #3149998: Auto-detect Drupal 8 and 9 codebase structure"...

  • Jon Pugh committed ab30235 on 7.x-4.x 
    Revert "Issue #3149998: Auto-detect Drupal 8 and 9 codebase structure (...
  • Jon Pugh committed ec98dc4 on 7.x-4.x
    Revert "Issue #3149998: Auto-detect Drupal 8 and 9 codebase structure"...

  • Jon Pugh committed 4afc72d on 7.x-4.x 
    Revert "Issue #3149998: Auto-detect Drupal 8 and 9 codebase structure"...
memtkmcc’s picture

memtkmcc commented

Yeah, it was actually a result of step by step debugging, since hooks are not something you can universally trust in Provision, after all those years of tech debt. Plus, the main intention was to add support for Drupal 9, and this was just a side-hack to make things work. The project was silent for too long, with very little or no progress at all, so we committed back whatever we could, even if it wasn't a polished elegance yet.

memtkmcc’s picture

memtkmcc commented

Oh wait, it wasn't intended for 7.x-4.x, not sure how that happened? You mean you merged in these two patches from 7.x-3.x?