Looking at some forms in the settings tray, I see that checkboxes are visually broken. There are also issues with tabledrag, and potentially other form elements.

We need to throw our form elements into settings tray and check to see what's broken, and then create one or more issues to fix.

CommentFileSizeAuthor
#20 layout-builder-form-olivero.png196.28 KBmherchel
#20 layout-builder-form-bartik.png199.73 KBmherchel
#12 Screenshot 2020-06-17 at 10.58.21 AM.png63.92 KBhimanshu_sindhwani
#12 Screenshot 2020-06-17 at 10.58.11 AM.png92.4 KBhimanshu_sindhwani
#11 Screenshot 2020-06-15 at 5.48.21 PM.png111.96 KBhimanshu_sindhwani
#6 3149714-6.patch573 bytespoojakural
#4 2.png232.34 KBshaktik
#4 1.png42.47 KBshaktik
#3 selected_8942.png827.81 KBKondratievaS
Edit_layout_for_sdf___Drupal_9_Stable-2.png63.63 KBmherchel

Comments

mherchel created an issue. See original summary.

poojakural’s picture

poojakural commented
Assigned: Unassigned » poojakural
KondratievaS’s picture

KondratievaS commented
StatusFileSize
new selected_8942.png827.81 KB

I have tested Olivero 8.x-1.0-alpha2 on Drupal 9.1.0-dev and can not reproduce issue reported in description - setting content opens in popins

OK

shaktik’s picture

shaktik
he/him
Primary language Hindi
Location New Delhi
commented
StatusFileSize
new 1.png42.47 KB
new 2.png232.34 KB

Hi @KondratievaS,

I am able to reproduce the issue reported in the description.

Steps:
1. Enable Layout Builder Module and check

2. example.com/admin/structure/types/manage/page/display/default/layout

attached the screenshot.

Thanks,
Shakti

poojakural’s picture

poojakural commented
Status: Active » Needs work
poojakural’s picture

poojakural commented
Status: Needs work » Needs review
StatusFileSize
new 3149714-6.patch573 bytes

Checkebox alignment issue has been fixed. Please refer the SS and patch.

Step to test
1. Enable Layout Builder Module and check
2. Go to this url (/admin/structure/types/manage/page/display/default/layout)
3. Click on "Add Block" option and choose any block to show.

@mherchel Not able to see menu item in the configue block. Could please provide the step to test.

Before Patch:
Only local images are allowed.

After Patch:
Only local images are allowed.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

Thanks. This issue is to create all form items within the settings tray and document when they look visually broken.

From there we'll set up one or more issues to create patches.

Things that I'd like to check:

  • tabledrag
  • input buttons
  • input submit
  • input text / date / search et al
  • selects in various locations
  • radio buttons
  • checkboxes
  • select multiple
  • anything else.
indrajithkb’s picture

indrajithkb commented

Hi @poojakural thanks for the patch please update the #6 patch with both SRC and DIST file.

poojakural’s picture

poojakural commented
Status: Needs review » Needs work
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

Once again, this issue isn't to create a patch to fix the checkbox issue, it's to audit form items that will appear within the settings tray. No patch.

himanshu_sindhwani’s picture

himanshu_sindhwani commented
StatusFileSize
new Screenshot 2020-06-15 at 5.48.21 PM.png111.96 KB

This is how multi-select looks on the settings tray:

multi-select

Dropdown arrow > is not visible present on left side of Toggle branding elements.

himanshu_sindhwani’s picture

himanshu_sindhwani commented
StatusFileSize
new Screenshot 2020-06-17 at 10.58.11 AM.png92.4 KB
new Screenshot 2020-06-17 at 10.58.21 AM.png63.92 KB

Tested the following Form elements on settings tray:

  1. Radio
  2. textarea
  3. textfield
  4. date
  5. color
  6. datelist
  7. email
  8. search
  9. Checkbox

Attaching the screenshots.
settings tray

settings tray

Creating issues for radio, checkbox and dropdown arrow.

poojakural’s picture

poojakural commented
Assigned: poojakural » Unassigned
hansa11’s picture

hansa11 commented
Status: Needs work » Active
asmita26’s picture

asmita26 commented
Assigned: Unassigned » asmita26
thedrupalkid’s picture

thedrupalkid commented

@aasmita: Are you working on this ?

hansa11’s picture

hansa11 commented

This issue is not to create a patch, please refer #7 and #10 :)

Once again, this issue isn't to create a patch to fix the checkbox issue, it's to audit form items that will appear within the settings tray. No patch.

Thanks!

himanshu_sindhwani’s picture

himanshu_sindhwani commented
Assigned: asmita26 » Unassigned

@asmita26, It is good if we don't assign such issues to ourselves so that anybody can work and post their findings.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Title: Audit form items within settings tray for visual inconsistencies » Olivero: Audit form items within settings tray for visual inconsistencies
Project: Olivero » Drupal core
Version: 8.x-1.0-alpha2 » 9.1.x-dev
Component: Code » Olivero theme
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Fixed
StatusFileSize
new layout-builder-form-bartik.png199.73 KB
new layout-builder-form-olivero.png196.28 KB

I went through and re-audited this since #3177238: Stronger visual affordance for Olivero's textbox form elements (Design only) is committed. It's looking good. I'm marking this as fixed.

Screenshots attached showing differences between Bartik and Olivero.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.