Drupal 9 Compatibility for Google Analytics Counter module [#3146542]

I created this issue for the consolidated deprecated code report for Drupal 9 compatibility/readiness.

The Upgrade Status Report:

Google Analytics Counter
Scanned on Fri, 06/05/2020 - 05:02.

6 errors found. 9 warnings found. Avoid some manual work by using drupal-rector
for fixing issues automatically or Upgrade Rector to generate patches.

web/modules/contrib/google_analytics_counter/src/GoogleAnalyticsCounterAppManage
r.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 123  │ Parameter $alias_manager of method                           │
│         │      │ Drupal\google_analytics_counter\GoogleAnalyticsCounterAppMan │
│         │      │ ager::__construct() has typehint with deprecated interface   │
│         │      │ Drupal\Core\Path\AliasManagerInterface. Deprecated in        │
│         │      │ drupal:8.8.0 and is removed from drupal:9.0.0. Use           │
│         │      │ Drupal\path_alias\AliasManagerInterface.                     │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/google_analytics_counter/src/GoogleAnalyticsCounterCustomFie
ldGenerator.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 152  │ Call to deprecated function entity_get_form_display().       │
│ rector   │      │ Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. │
│          │      │ Use EntityDisplayRepositoryInterface::getFormDisplay()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
│ Fix with │ 162  │ Call to deprecated function entity_get_display(). Deprecated │
│ rector   │      │ in drupal:8.8.0 and is removed from drupal:9.0.0. Use        │
│          │      │ EntityDisplayRepositoryInterface::getViewDisplay() instead.  │
│          │      │                                                              │
│ Fix with │ 171  │ Call to deprecated method entityManager() of class Drupal.   │
│ rector   │      │ Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. │
│          │      │ Use Drupal::entityTypeManager() instead in most cases. If    │
│          │      │ the needed method is not on                                  │
│          │      │ \Drupal\Core\Entity\EntityTypeManagerInterface, see the      │
│          │      │ deprecated \Drupal\Core\Entity\EntityManager to find the     │
│          │      │ correct interface or service.                                │
│          │      │                                                              │
│ Fix with │ 173  │ Call to deprecated function entity_get_display(). Deprecated │
│ rector   │      │ in drupal:8.8.0 and is removed from drupal:9.0.0. Use        │
│          │      │ EntityDisplayRepositoryInterface::getViewDisplay() instead.  │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/google_analytics_counter/src/Plugin/Filter/GoogleAnalyticsCo
unterFilter.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 72   │ Parameter $alias_manager of method                           │
│         │      │ Drupal\google_analytics_counter\Plugin\Filter\GoogleAnalytic │
│         │      │ sCounterFilter::__construct() has typehint with deprecated   │
│         │      │ interface Drupal\Core\Path\AliasManagerInterface. Deprecated │
│         │      │ in drupal:8.8.0 and is removed from drupal:9.0.0. Use        │
│         │      │ Drupal\path_alias\AliasManagerInterface.                     │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/google_analytics_counter/tests/src/Functional/GoogleAnalytic
sCounterAuthSettingsTest.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found and could not be │
│ manually │      │ autoloaded.                                                 │
│          │      │                                                             │
│ Check    │ 12   │ Class PHPUnit\Framework\TestCase not found and could not be │
│ manually │      │ autoloaded.                                                 │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

web/modules/contrib/google_analytics_counter/tests/src/Functional/GoogleAnalytic
sCounterBlockTest.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found and could not be │
│ manually │      │ autoloaded.                                                 │
│          │      │                                                             │
│ Check    │ 17   │ Class PHPUnit\Framework\TestCase not found and could not be │
│ manually │      │ autoloaded.                                                 │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

web/modules/contrib/google_analytics_counter/tests/src/Functional/GoogleAnalytic
sCounterSettingsTest.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found and could not be │
│ manually │      │ autoloaded.                                                 │
│          │      │                                                             │
│ Check    │ 12   │ Class PHPUnit\Framework\TestCase not found and could not be │
│ manually │      │ autoloaded.                                                 │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

web/modules/contrib/google_analytics_counter/tests/src/Kernel/GoogleAnalyticsCou
nterQueueTest.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found and could not be │
│ manually │      │ autoloaded.                                                 │
│          │      │                                                             │
│ Check    │ 12   │ Class PHPUnit\Framework\TestCase not found and could not be │
│ manually │      │ autoloaded.                                                 │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

web/modules/contrib/google_analytics_counter/google_analytics_counter.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add <code>core_version_requirement: ^8 || ^9

to │
│ manually │ │ modules/contrib/google_analytics_counter/google_analytics_co │
│ │ │ unter.info.yml to designate that the module is compatible │
│ │ │ with Drupal 9. See https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

Drupal-check utility tool report:

 26/26 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -----------------------------------------------------------------------
  Line   src/GoogleAnalyticsCounterAppManager.php
 ------ -----------------------------------------------------------------------
  123    Parameter $alias_manager of method
         Drupal\google_analytics_counter\GoogleAnalyticsCounterAppManager::__c
         onstruct() has typehint with deprecated interface
         Drupal\Core\Path\AliasManagerInterface:
         in drupal:8.8.0 and is removed from drupal:9.0.0.
         Use \Drupal\path_alias\AliasManagerInterface.
 ------ -----------------------------------------------------------------------

 ------ -----------------------------------------------------------------------
  Line   src/GoogleAnalyticsCounterCustomFieldGenerator.php
 ------ -----------------------------------------------------------------------
  152    Call to deprecated function entity_get_form_display():
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getFormDisplay() instead.
  162    Call to deprecated function entity_get_display():
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getViewDisplay() instead.
  171    Call to deprecated method entityManager() of class Drupal:
         in drupal:8.0.0 and is removed from drupal:9.0.0.
         Use \Drupal::entityTypeManager() instead in most cases. If the needed
         method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see
         the
         deprecated \Drupal\Core\Entity\EntityManager to find the
         correct interface or service.
  173    Call to deprecated function entity_get_display():
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getViewDisplay() instead.
 ------ -----------------------------------------------------------------------

 ------ -----------------------------------------------------------------------
  Line   src/Plugin/Filter/GoogleAnalyticsCounterFilter.php
 ------ -----------------------------------------------------------------------
  72     Parameter $alias_manager of method
         Drupal\google_analytics_counter\Plugin\Filter\GoogleAnalyticsCounterF
         ilter::__construct() has typehint with deprecated interface
         Drupal\Core\Path\AliasManagerInterface:
         in drupal:8.8.0 and is removed from drupal:9.0.0.
         Use \Drupal\path_alias\AliasManagerInterface.
 ------ -----------------------------------------------------------------------

 ------ -----------------------------------------------------------------
  Line   tests/src/Functional/GoogleAnalyticsCounterAuthSettingsTest.php
 ------ -----------------------------------------------------------------
         Class PHPUnit\Framework\TestCase not found and could not be
         autoloaded.
         💡 Learn more at https://phpstan.org/user-guide/autoloading
  12     Class PHPUnit\Framework\TestCase not found and could not be
         autoloaded.
         💡 Learn more at https://phpstan.org/user-guide/autoloading
 ------ -----------------------------------------------------------------

 ------ -------------------------------------------------------------
  Line   tests/src/Functional/GoogleAnalyticsCounterBlockTest.php
 ------ -------------------------------------------------------------
         Class PHPUnit\Framework\TestCase not found and could not be
         autoloaded.
         💡 Learn more at https://phpstan.org/user-guide/autoloading
  17     Class PHPUnit\Framework\TestCase not found and could not be
         autoloaded.
         💡 Learn more at https://phpstan.org/user-guide/autoloading
 ------ -------------------------------------------------------------

 ------ -------------------------------------------------------------
  Line   tests/src/Functional/GoogleAnalyticsCounterSettingsTest.php
 ------ -------------------------------------------------------------
         Class PHPUnit\Framework\TestCase not found and could not be
         autoloaded.
         💡 Learn more at https://phpstan.org/user-guide/autoloading
  12     Class PHPUnit\Framework\TestCase not found and could not be
         autoloaded.
         💡 Learn more at https://phpstan.org/user-guide/autoloading
 ------ -------------------------------------------------------------

 ------ -------------------------------------------------------------
  Line   tests/src/Kernel/GoogleAnalyticsCounterQueueTest.php
 ------ -------------------------------------------------------------
         Class PHPUnit\Framework\TestCase not found and could not be
         autoloaded.
         💡 Learn more at https://phpstan.org/user-guide/autoloading
  12     Class PHPUnit\Framework\TestCase not found and could not be
         autoloaded.
         💡 Learn more at https://phpstan.org/user-guide/autoloading
 ------ -------------------------------------------------------------

 [ERROR] Found 14 errors

Comment	File	Size	Author
#22	drupal-9-compatibility-for-google-analytics-counter-module-3146542-22.patch	94.01 KB	kakoum
#20	interdiff_18-19.txt	70.42 KB	osopolar
#19	interdiff_18-19.txt	566 bytes	rishi.kulshreshtha
#19	drupal-9-compatibility-for-google-analytics-counter-module-3146542-19.patch	79.44 KB	rishi.kulshreshtha
#18	interdiff_17-18.txt	7.45 KB	rishi.kulshreshtha
#18	drupal_9_compatibility_report-3146542-18.patch	14.53 KB	rishi.kulshreshtha
#17	drupal_9_compatibility_report-3146542-17.patch	13.41 KB	isa.bel
#11	interdiff_8-11.txt	839 bytes	vetal4ik
#11	drupal_9_compatibility_report-3146542-11.patch	12.38 KB	vetal4ik
#8	drupal_9_compatibility_report-3146542-8.patch	11.62 KB	drupal.ninja03
#8	interdiff_3146542-7-8.txt	5.17 KB	drupal.ninja03
#7	drupal_9_compatibility_report-3146542-7.patch	6.95 KB	gnanagowthaman sankar
#7	interdiff_6-7.txt	446 bytes	gnanagowthaman sankar
#6	drupal_9_compatibility_report-3146542-6.patch	6.96 KB	gnanagowthaman sankar
#6	interdiff_3-6.txt	2.57 KB	gnanagowthaman sankar
#3	Drupal_9_Compatibility_report-3146542-3.patch	4.17 KB	gnanagowthaman sankar

Issue fork google_analytics_counter-3146542

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1 hidden branch

3146542-drupal-9-compatibility

changes, plain diff MR !5

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

5 June 2020 at 10:04

drupal.ninja03 created an issue. See original summary.

Comment #2

siddhant.bhosale commented 5 June 2020 at 10:55

Assigned:

Unassigned

» siddhant.bhosale

Comment #3

gnanagowthaman sankar commented 6 June 2020 at 08:47

Assigned:	siddhant.bhosale	» gnanagowthaman sankar
Status:	Active	» Needs review

Status	File	Size
new	Drupal_9_Compatibility_report-3146542-3.patch	4.17 KB

Hi @siddhant.bhosale,

Here by i attached the patch please review and let me know for any changes.

Thanks & Regards,
GnanagowthamanSankar

Comment #4

drupal.ninja03 commented 6 June 2020 at 09:11

Status:

Needs review

» Needs work

Tested the patch from #3, and ran the upgrade status scan again:

Google Analytics Counter
Scanned on Sat, 06/06/2020 - 04:06.

2 errors found. 8 warnings found.

web/modules/contrib/google_analytics_counter/src/GoogleAnalyticsCounterAppManage
r.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 123  │ Parameter $alias_manager of method                           │
│         │      │ Drupal\google_analytics_counter\GoogleAnalyticsCounterAppMan │
│         │      │ ager::__construct() has typehint with deprecated interface   │
│         │      │ Drupal\Core\Path\AliasManagerInterface. Deprecated in        │
│         │      │ drupal:8.8.0 and is removed from drupal:9.0.0. Use           │
│         │      │ Drupal\path_alias\AliasManagerInterface.                     │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/google_analytics_counter/src/Plugin/Filter/GoogleAnalyticsCo
unterFilter.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 72   │ Parameter $alias_manager of method                           │
│         │      │ Drupal\google_analytics_counter\Plugin\Filter\GoogleAnalytic │
│         │      │ sCounterFilter::__construct() has typehint with deprecated   │
│         │      │ interface Drupal\Core\Path\AliasManagerInterface. Deprecated │
│         │      │ in drupal:8.8.0 and is removed from drupal:9.0.0. Use        │
│         │      │ Drupal\path_alias\AliasManagerInterface.                     │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

Comment #5

drupal.ninja03 commented 6 June 2020 at 10:23

There are few warnings related to tests:

web/modules/contrib/google_analytics_counter/tests/src/Functional/GoogleAnalytic
sCounterAuthSettingsTest.php:
┌──────────┬──────┬───────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                        MESSAGE                        │
├──────────┼──────┼───────────────────────────────────────────────────────┤
│ Check    │      │ Class Behat\Mink\WebAssert not found and could not be │
│ manually │      │ autoloaded.                                           │
│          │      │                                                       │
│ Check    │ 53   │ Class Behat\Mink\WebAssert not found and could not be │
│ manually │      │ autoloaded.                                           │
│          │      │                                                       │
└──────────┴──────┴───────────────────────────────────────────────────────┘

web/modules/contrib/google_analytics_counter/tests/src/Functional/GoogleAnalytic
sCounterBlockTest.php:
┌──────────┬──────┬───────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                        MESSAGE                        │
├──────────┼──────┼───────────────────────────────────────────────────────┤
│ Check    │      │ Class Behat\Mink\WebAssert not found and could not be │
│ manually │      │ autoloaded.                                           │
│          │      │                                                       │
│ Check    │ 139  │ Class Behat\Mink\WebAssert not found and could not be │
│ manually │      │ autoloaded.                                           │
│          │      │                                                       │
└──────────┴──────┴───────────────────────────────────────────────────────┘

web/modules/contrib/google_analytics_counter/tests/src/Functional/GoogleAnalytic
sCounterSettingsTest.php:
┌──────────┬──────┬───────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                        MESSAGE                        │
├──────────┼──────┼───────────────────────────────────────────────────────┤
│ Check    │      │ Class Behat\Mink\WebAssert not found and could not be │
│ manually │      │ autoloaded.                                           │
│          │      │                                                       │
│ Check    │ 64   │ Class Behat\Mink\WebAssert not found and could not be │
│ manually │      │ autoloaded.                                           │
│          │      │                                                       │
└──────────┴──────┴───────────────────────────────────────────────────────┘

Not sure how this should be handled.

Comment #6

gnanagowthaman sankar commented 6 June 2020 at 09:45

Status:

Needs work

» Needs review

Status	File	Size
new	interdiff_3-6.txt	2.57 KB
new	drupal_9_compatibility_report-3146542-6.patch	6.96 KB

Hi @drupal.ninja03,

I attached the updated patch for your reference except the test case. Please review and let me know for the changes.

Thanks & regards,
GnanagowthamanSankar

Comment #7

gnanagowthaman sankar commented 6 June 2020 at 09:52

Status	File	Size
new	interdiff_6-7.txt	446 bytes
new	drupal_9_compatibility_report-3146542-7.patch	6.95 KB

Hi @drupal.ninja03,

I had made some changes in the version can you please review the patch.

Thanks & regards,
GnanagowthamanSankar

Comment #8

drupal.ninja03 commented 6 June 2020 at 11:20

Status	File	Size
new	interdiff_3146542-7-8.txt	5.17 KB
new	drupal_9_compatibility_report-3146542-8.patch	11.62 KB

Patch from #7 works. and the upgrade status report show no more errors. However, when I tested with D9 site, I faced errors for deprecated services: path.alias_manager & entity.manager and had to make the corrections to path_alias.manager & entity_type.manager and created the patch for the same. Tested against 8.8.9 & 9.0.0.

Comment #9

gnanagowthaman sankar commented 6 June 2020 at 11:46

Thanks @drupal.ninja03

Comment #10

szeidler

German

Berlin

commented 8 February 2021 at 18:17

Status:

Needs review

» Reviewed & tested by the community

This looks pretty good. It would be awesome, if we could commit and tag a Drupal 9 compatible release.

Comment #11

vetal4ik commented 16 June 2021 at 12:32

Status:

Reviewed & tested by the community

» Needs review

Status	File	Size
new	drupal_9_compatibility_report-3146542-11.patch	12.38 KB
new	interdiff_8-11.txt	839 bytes

2 files were hidden/shown/deleted

Status	File	Size
hidden	interdiff_3146542-7-8.txt	5.17 KB
hidden	drupal_9_compatibility_report-3146542-8.patch	11.62 KB

After applying the patch from #8 I got the next error:

The website encountered an unexpected error. Please try again later.
ArgumentCountError: Too few arguments to function Drupal\google_analytics_counter\GoogleAnalyticsCounterCustomFieldGenerator::__construct(), 4 passed in /var/www/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 257 and exactly 5 expected in Drupal\google_analytics_counter\GoogleAnalyticsCounterCustomFieldGenerator->__construct() (line 83 of modules/contrib/google_analytics_counter/src/GoogleAnalyticsCounterCustomFieldGenerator.php).
Drupal\google_analytics_counter\GoogleAnalyticsCounterCustomFieldGenerator->__construct(Object, Object, Object, Object) (Line: 257)
Drupal\Component\DependencyInjection\Container->createService(Array, 'google_analytics_counter.custom_field_generator') (Line: 171)
Drupal\Component\DependencyInjection\Container->get('google_analytics_counter.custom_field_generator') (Line: 67)
Drupal\google_analytics_counter\Form\GoogleAnalyticsCounterConfigureTypesForm::create(Object) (Line: 28)
Drupal\Core\DependencyInjection\ClassResolver->getInstanceFromDefinition('\Drupal\google_analytics_counter\Form\GoogleAnalyticsCounterConfigureTypesForm') (Line: 48)
Drupal\Core\Controller\HtmlFormController->getFormObject(Object, '\Drupal\google_analytics_counter\Form\GoogleAnalyticsCounterConfigureTypesForm') (Line: 58)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
...

The problem was in missed dependency for `google_analytics_counter.custom_field_generator` service.

Comment #12

rajab natshah

he/him

commented 16 August 2021 at 14:09

Assigned:	gnanagowthaman sankar	» Unassigned
Priority:	Normal	» Critical

Comment #13

rajab natshah

he/him

commented 19 August 2021 at 07:08

Title:

Drupal 9 Compatibility report

» Drupal 9 Compatibility for Google Analytics Counter module

Comment #14

16 September 2021 at 12:49

NicholasS made their first commit to this issue’s fork.

Comment #15

8 October 2021 at 08:26

slv_ made their first commit to this issue’s fork.

Comment #16

14 October 2021 at 13:45

Grimreaper opened merge request !5

Comment #17

isa.bel

Portuguese, Brazil

Balneário Camboriú

commented 20 October 2021 at 13:46

Status	File	Size
new	drupal_9_compatibility_report-3146542-17.patch	13.41 KB

For d9 upgrade the SafeMarkup::checkPlain is also showing as a compatibility error:
Error: Class 'Drupal\Component\Utility\SafeMarkup' not found in Drupal\google_analytics_counter\GoogleAnalyticsCounterAppManager->gacUpdatePathCounts()

I've added this change to the provided patch on this issue and I'm attaching it here.

Comment #18

rishi.kulshreshtha

He/Him

English

Portland, Maine

commented 25 October 2021 at 15:40

Status	File	Size
new	drupal_9_compatibility_report-3146542-18.patch	14.53 KB
new	interdiff_17-18.txt	7.45 KB

Frist, the provided patch is broken when applied with 8.x-3.x-dev. Second, the patch is still missing a lot of D9 in compatibilities, hence providing an updated patch here with interdiff.

Processing /var/www/html/modules/contrib/google_analytics_counter.

================================================================================
Google Analytics Counter, --
Scanned on Mon, 10/25/2021 - 15:29

FILE: modules/contrib/google_analytics_counter/google_analytics_counter.install

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix now        240  Call to deprecated method getStorage() of class             
                    Drupal\Core\Entity\EntityManager. Deprecated in drupal:8.0.0
                    and is removed from drupal:9.0.0. Use                       
                    Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() 
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 240  The "entity.manager" service is deprecated. You should use  
                    the 'entity_type.manager' service instead.                  
--------------------------------------------------------------------------------

FILE:
modules/contrib/google_analytics_counter/src/Form/GoogleAnalyticsCounterAuthForm
.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 182  The "path.alias_manager" service is deprecated. Use         
                    "path_alias.manager" instead. See                           
                    https://drupal.org/node/3092086                             
--------------------------------------------------------------------------------

FILE:
modules/contrib/google_analytics_counter/src/Form/GoogleAnalyticsCounterConfigur
eTypesForm.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix now        155  Call to deprecated method getStorage() of class             
                    Drupal\Core\Entity\EntityManager. Deprecated in drupal:8.0.0
                    and is removed from drupal:9.0.0. Use                       
                    Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() 
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 155  The "entity.manager" service is deprecated. You should use  
                    the 'entity_type.manager' service instead.                  
--------------------------------------------------------------------------------

FILE:
modules/contrib/google_analytics_counter/src/GoogleAnalyticsCounterCustomFieldGe
nerator.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 159  Call to deprecated function entity_get_form_display().      
                    Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0.
                    Use EntityDisplayRepositoryInterface::getFormDisplay()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 169  Call to deprecated function entity_get_display(). Deprecated
                    in drupal:8.8.0 and is removed from drupal:9.0.0. Use       
                    EntityDisplayRepositoryInterface::getViewDisplay() instead. 
--------------------------------------------------------------------------------
Check manually 178  Call to deprecated method entityManager() of class Drupal.  
                    Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0.
                    Use Drupal::entityTypeManager() instead in most cases. If   
                    the needed method is not on                                 
                    \Drupal\Core\Entity\EntityTypeManagerInterface, see the     
                    deprecated \Drupal\Core\Entity\EntityManager to find the    
                    correct interface or service.                               
--------------------------------------------------------------------------------
Check manually 180  Call to deprecated function entity_get_display(). Deprecated
                    in drupal:8.8.0 and is removed from drupal:9.0.0. Use       
                    EntityDisplayRepositoryInterface::getViewDisplay() instead. 
--------------------------------------------------------------------------------

FILE:
modules/contrib/google_analytics_counter/tests/src/Functional/GoogleAnalyticsCou
nterAuthSettingsTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 12   Drupal\Tests\BrowserTestBase::$defaultTheme is required. See
                    https://www.drupal.org/node/3083055, which includes         
                    recommendations on which theme to use.                      
--------------------------------------------------------------------------------

FILE:
modules/contrib/google_analytics_counter/tests/src/Functional/GoogleAnalyticsCou
nterBlockTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 17   Drupal\Tests\BrowserTestBase::$defaultTheme is required. See
                    https://www.drupal.org/node/3083055, which includes         
                    recommendations on which theme to use.                      
--------------------------------------------------------------------------------

FILE:
modules/contrib/google_analytics_counter/tests/src/Functional/GoogleAnalyticsCou
nterSettingsTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 12   Drupal\Tests\BrowserTestBase::$defaultTheme is required. See
                    https://www.drupal.org/node/3083055, which includes         
                    recommendations on which theme to use.                      
--------------------------------------------------------------------------------

FILE:
modules/contrib/google_analytics_counter/tests/src/Kernel/GoogleAnalyticsCounter
QueueTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         61   Call to deprecated constant REQUEST_TIME: Deprecated in     
                    drupal:8.3.0 and is removed from drupal:10.0.0. Use         
                    Drupal::time()->getRequestTime();                           
--------------------------------------------------------------------------------

Comment #19

rishi.kulshreshtha

He/Him

English

Portland, Maine

commented 29 October 2021 at 15:39

Status	File	Size
new	drupal-9-compatibility-for-google-analytics-counter-module-3146542-19.patch	79.44 KB
new	interdiff_18-19.txt	566 bytes

Updating patch for missed code.

Comment #20

osopolar

German

🇩🇪 GER 🌐

commented 17 November 2021 at 03:33

Status	File	Size
new	interdiff_18-19.txt	70.42 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	interdiff_18-19.txt	566 bytes

Recreating interdiff

interdiff drupal_9_compatibility_report-3146542-18.patch drupal-9-compatibility-for-google-analytics-counter-module-3146542-19.patch > interdiff_18-19.txt

Shouldn't coding standard issues be better fixed in a separate issue? To me there are too many changes for reviewing.

Comment #21

szeidler

German

Berlin

commented 17 November 2021 at 05:56

Shouldn't coding standard issues be better fixed in a separate issue? To me there are too many changes for reviewing

Yes

Comment #22

kakoum commented 17 January 2022 at 14:52

Status	File	Size
new	drupal-9-compatibility-for-google-analytics-counter-module-3146542-22.patch	94.01 KB

My patch (compatibilty D9) for version 8.x-3.0-alpha19

Comment #23

kakoum commented 17 January 2022 at 14:53

1 file was hidden/shown/deleted

Status	File	Size
hidden	drupal-9-compatibility-for-google-analytics-counter-module-3146542-22.patch	94.01 KB

Comment #24

kakoum commented 17 January 2022 at 14:55

1 file was hidden/shown/deleted

Status	File	Size
shown	drupal-9-compatibility-for-google-analytics-counter-module-3146542-22.patch	94.01 KB

Comment #25

kaszarobert

Hungarian

commented 17 May 2022 at 20:02

Assigned:	Unassigned	» kaszarobert
Status:	Needs review	» Needs work

Patch couldn't be applied to the latest dev. I'm doing a reroll and release a new D9 compatible alpha version.

Comment #26

ericdsd commented 18 May 2022 at 09:25

Hi that's good to hear, i'll test it once you release it.

Comment #27

18 May 2022 at 19:52

kaszarobert committed 9c4b985 on 8.x-3.x

Issue #3146542 by Gnanagowthaman sankar, Rishi Kulshreshtha, szeidler,...

Comment #28

kaszarobert

Hungarian

commented 18 May 2022 at 20:00

Assigned:	kaszarobert	» Unassigned
Status:	Needs work	» Fixed

Committed. Thank you for everyone's hard work! I saw that the patches also trying to solve codestyle problems, too. I will commit those under #3281212: Fix code style issues as there's too many of those solve at once.

Now, at least the module works with Drupal 9. There are still a ton of bugs to solve but it's a small step towards a stable release.

Comment #29

21 May 2022 at 13:08

kaszarobert committed 3c65a0c on 8.x-3.x

Issue #3146542 Compatibility fixes for existing tests

Comment #30

21 May 2022 at 14:41

kaszarobert closed merge request !5

Comment #31

4 June 2022 at 14:44

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Drupal 9 Compatibility for Google Analytics Counter module

Issue fork google_analytics_counter-3146542

Comments

Referenced by