Steps to Replicate -
1. Go to Content ->Add Content -> Article Page /Basic page -> Create Article /Create Basic page
2. Select text format -> full Html
3. Insert the table using CKEditor select the table properties.
Attached the screen shot for the reference.
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | 3146535-24.patch | 12.14 KB | mherchel |
| #23 | 3146535-22.patch | 746 bytes | mherchel |
| #20 | 3146535-after-patch-19.png | 24.76 KB | indrajithkb |
| #19 | ckeditor_dialog_table_themeing_fix-3146535-19.patch | 12.11 KB | sreenivas bttv |
| #18 | 3146535-expected.png | 4.1 KB | indrajithkb |
Comments
Comment #2
sreenivas bttv commentedComment #3
poojakural commented@Sreenivas Are you working on it. It been a 4 days you have assigned to yourself
Comment #4
sreenivas bttv commentedYes, @poojakural. I am working on this. Almost finished. Going to raise patch today.
Comment #5
sreenivas bttv commentedPlease review the patch.
The patch contains a new component related to CKEditor dialog table CSS, which fixes the theming of the table inside CKEditor dialog and respected input elements.
Comment #6
sreenivas bttv commentedThe gif reference of #5 patch.
Comment #7
indrajithkb commentedHi @Sreenivas Bttv , Your patch #5 showing you forgot to add the DIST file. When you are creating patch please make sure you are adding both files SRC and DIST.
Just go through this link: https://www.drupal.org/docs/8/themes/olivero/development-setup
Comment #8
indrajithkb commentedComment #9
komalk commentedpatch #5 is applied successfully.
#9 added complied css.
attached the screen shot for the reference.
Comment #10
sreenivas bttv commented@Indrajith KB,
As mentioned in https://www.drupal.org/docs/8/themes/olivero/development-setup, while creating a patch mentioned that When making changes, the patch should only contain changes to the source CSS files. .
So as part of #5 patch only included source CSS files.
Thanks for reviewing the patch.
Comment #11
indrajithkb commentedHi @komalkolekar thanks for adding the patch. It's fixing the issue. But am facing some css linting issue. For a better practice check the css linting also.
yarn run lint:cssPlease update your patch.
Comment #12
indrajithkb commentedComment #13
sreenivas bttv commentedPlease review the patch which extends of #5 after fixing linting issues.
Comment #14
mherchelI don't want this CSS to load in the main bundle. Can we extend a core library and only load it then?
Comment #15
sreenivas bttv commented@mherchel,
Need more information. Means expecting to create separate library inside olivero.libraries.yml and add it to libraries-extend: inside olivero.info.yml. Please confirm
Comment #16
mherchelExactly. Create a separate library, and have that only load when CKEditor loads via libraries-extend.
Comment #17
sreenivas bttv commentedPlease review the patch.
Created a separate library and extended CKEditor using libraries-extend.
Comment #18
indrajithkb commentedHi @Sreenivas Bttv good work. I confirmed the file is loading when CKEditor loads , but one small issue i found hover,focus state of the Select behaviour.
Current behaviour:
Expected behaviour:
Comment #19
sreenivas bttv commentedPlease review patch updated select element with border on focus.
Comment #20
indrajithkb commentedhI @Sreenivas Bttv thanks for #19, issue has found fixed. Attaching the screenshot after applying the patch.
Comment #21
mherchelComment #22
mherchelThis looks great! Re-rolling the patch. The only modification is a code comment for the reason of
!importantComment #23
mherchelAttaching the patch!
Comment #24
mherchelOops. Bungled the patch. One more time.
Comment #25
mherchelCommitted. Thanks!