Remove Unused variable $next from AggregatorController.php file

Interestingly it's a legacy code :)

+++ b/core/modules/aggregator/src/Controller/AggregatorController.php
@@ -125,7 +125,7 @@ public function adminOverview() {
+        $next_update = $this->t('%time left', ['%time' => $this->dateFormatter->formatInterval($last_checked + $refresh_rate - REQUEST_TIME)]);

Should not the REQUEST_TIME be replaced with the \Drupal::time()->getRequestTime()?

@DevJoJodae Hi i think this is the deprecation it would be great if we can create separate ticket for deprecation.

Yes, using a service instead of a constant is out of topic for this issue, which is about removing a variable that isn't used.

Yes, the $next variable is initialized, but never used. This patch removes every reference to that variable from the code.

I also verified the code used from the AggregatorController class doesn't contain other references to that variable.

Typically, when I see unused variables, I like to know why they're there (as sometimes it can be covering up other bugs).

• I used git log -L for the elseif, and it looks like the variable definition was added in #2228823: Aggregator feed overview misleading text .
• I checked out the commit from that issue (12b8a2f77) and verified that the variable was also unused in the original commit.
• It also did not exist in the commit before that one.
• Reading interdiffs on #2228823: Aggregator feed overview misleading text , it looks like the variable was named $next in the original patch, and was renamed without explanation in comment 4 of that issue (with no changes to the logic). That's when the duplication was introduced.

So, it looks like this is indeed a safe cleanup.

As a cleanup of dead code for a local variable, this is eligible for backport to the production branch. So, committed to 9.1.x, and cherry-picked to 9.0.x and 8.9.x. Thanks!