Closed (fixed)
Project:
Olivero
Version:
8.x-1.0-alpha2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Jun 2020 at 16:55 UTC
Updated:
2 Jul 2020 at 12:24 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
poojakural commentedComment #3
poojakural commentedChecked the issue. Table header z index causing issue. Please refer the SS and patch
Step to Test:
Comment #4
poojakural commentedComment #5
hansa11 commented@poojakural: Thank you for your contribution :)
I reviewed your patch, though it looks good, I have a few observations:
1. When you apply
z-index:0, that resolves the issue of header and table header overlapping with each other, but then theSticky Headerfunctionality for the table doesn't work as the table header goes right behind the site header.2. To resolve this we can have the
table-headerto stop right below theSite headerwhen the site header is expanded and when the site header is not expanded it will work as usual (i.e will stop at the top).Thanks!
Comment #6
shalinigaur commentedComment #7
poojakural commented@hansa11 Thank you for reviewing my patch. Here are my some observation:
1. When you apply z-index:0, that resolves the issue of header and table header overlapping with each other, but then the Sticky Header functionality for the table doesn't work as the table header goes right behind the site header.
[I think this is excepted behaviour. As header menu is primary block which remain at the top whether other block item is position fixed ]
2. To resolve this we can have the table-header to stop right below the Site header when the site header is expanded and when the site header is not expanded it will work as usual (i.e will stop at the top).
[header also have a search block. As per the suggested changes. Need to move down the sticky table header twice one when header opens and other search block opens and move up when these blocks hides. In my opinion this is not a good user experience. Please refer the SS
Comment #8
indrajithkb commentedHi @poojakural , yes your solution is looking good, actually the core sticky-header module adds z-index:500 to the table header so overriding the z-index with '0' is the solution. that's you done. But we need to take care of while adding patch please ensure that you are adding both the SRC and DIST file.
Please go through the document as well https://www.drupal.org/docs/8/themes/olivero/development-setup
so please re-roll the patch with both files.
Adding the screenshots just for confirming about the fixes.
Before patch:
After patch:
Comment #9
indrajithkb commentedComment #10
poojakural commentedComment #11
poojakural commented@Indrajith thank u for checking the patch. Made changes. please review the patch
Comment #12
poojakural commented@Indrajith ignore the above patch[3144915-11.patch]. please refer this patch
Comment #13
poojakural commented@Indrajith ignore the above patch[3144915-11 & 3144915-12]. please refer this patch
Comment #14
poojakural commentedGetting some linting issue in code. coding issue fixed. Please refer the uploaded patch
Comment #15
indrajithkb commentedHi @poojakural greak work, yes we need to check the linting also. the issue has found fixed. Not adding the screenshots again. For screen shots please refer the #8 comment.
Comment #17
mherchelCommitted! Thanks!
https://git.drupalcode.org/project/olivero/-/commit/b2182eb881111ee8b4d1...