I have a page with a table generated by a view which has Drupal sticky headers enabled. When using Olivero as the theme, as I scroll down to the table, the header collapses and the page is fine. The sticky table headers work as expected. But if I click on the top left corner to show the header, it overlaps the table headers and gets cut like this screenshot. You can also see it live on https://new-look-d5es5zy-44kyhbregllis.us.platform.sh/

Comments

hussainweb created an issue. See original summary.

poojakural’s picture

Assigned: Unassigned » poojakural
poojakural’s picture

StatusFileSize
new150.79 KB
new139.08 KB
new344 bytes

Checked the issue. Table header z index causing issue. Please refer the SS and patch
Step to Test:

  • Create a view page
  • Make a view list with table format and check Enable Drupal style "sticky" table headers (Javascript) in the table setting.
  • then open the view page and check the table header after clicking on header
poojakural’s picture

Assigned: poojakural » Unassigned
Status: Active » Needs review
hansa11’s picture

Status: Needs review » Needs work

@poojakural: Thank you for your contribution :)

I reviewed your patch, though it looks good, I have a few observations:

1. When you apply z-index:0, that resolves the issue of header and table header overlapping with each other, but then the Sticky Header functionality for the table doesn't work as the table header goes right behind the site header.

2. To resolve this we can have the table-header to stop right below the Site header when the site header is expanded and when the site header is not expanded it will work as usual (i.e will stop at the top).

Thanks!

shalinigaur’s picture

Assigned: Unassigned » shalinigaur
poojakural’s picture

Assigned: shalinigaur » Unassigned
Status: Needs work » Needs review
StatusFileSize
new136.77 KB
new208.04 KB

@hansa11 Thank you for reviewing my patch. Here are my some observation:
1. When you apply z-index:0, that resolves the issue of header and table header overlapping with each other, but then the Sticky Header functionality for the table doesn't work as the table header goes right behind the site header.
[I think this is excepted behaviour. As header menu is primary block which remain at the top whether other block item is position fixed ]

2. To resolve this we can have the table-header to stop right below the Site header when the site header is expanded and when the site header is not expanded it will work as usual (i.e will stop at the top).
[header also have a search block. As per the suggested changes. Need to move down the sticky table header twice one when header opens and other search block opens and move up when these blocks hides. In my opinion this is not a good user experience. Please refer the SS

indrajithkb’s picture

Hi @poojakural , yes your solution is looking good, actually the core sticky-header module adds z-index:500 to the table header so overriding the z-index with '0' is the solution. that's you done. But we need to take care of while adding patch please ensure that you are adding both the SRC and DIST file.
Please go through the document as well https://www.drupal.org/docs/8/themes/olivero/development-setup

so please re-roll the patch with both files.

Adding the screenshots just for confirming about the fixes.

Before patch:

before patch

After patch:

after patch

indrajithkb’s picture

Status: Needs review » Needs work
poojakural’s picture

Assigned: Unassigned » poojakural
poojakural’s picture

Assigned: poojakural » Unassigned
Status: Needs work » Needs review
StatusFileSize
new344 bytes

@Indrajith thank u for checking the patch. Made changes. please review the patch

poojakural’s picture

StatusFileSize
new684 bytes

@Indrajith ignore the above patch[3144915-11.patch]. please refer this patch

poojakural’s picture

StatusFileSize
new682 bytes

@Indrajith ignore the above patch[3144915-11 & 3144915-12]. please refer this patch

poojakural’s picture

StatusFileSize
new682 bytes

Getting some linting issue in code. coding issue fixed. Please refer the uploaded patch

indrajithkb’s picture

Status: Needs review » Reviewed & tested by the community

Hi @poojakural greak work, yes we need to check the linting also. the issue has found fixed. Not adding the screenshots again. For screen shots please refer the #8 comment.

  • mherchel committed b2182eb on 8.x-1.x authored by poojakural
    Issue #3144915 by poojakural, Indrajith KB, hussainweb, hansa11: Sticky...
mherchel’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.