Problem

Many forms have two submit buttons. One of these will have the "button--primary" CSS class, and thus be styled with a solid blue color.

Some forms, such as the "Create New Account" form, have this CSS class added.

Many more forms, including the login, request new password, and search block forms, do not have this CSS class added.

Task

This task is to create a form alter that checks if there is only one submit button, and if so, ensures that the button--primaryis added to it.

CommentFileSizeAuthor
#11 search-form-advanced-after-patch_11.png105.78 KBnitesh624
#11 search-form-basic-after-patch_11.png104.54 KBnitesh624
#11 interdiff_4-11.txt1007 bytesnitesh624
#11 3143852-11.patch1.06 KBnitesh624
#8 3143852-reset-pwd-after-patch.png73.53 KBindrajithkb
#8 3143852-reset-pwd-before-patch.png72.95 KBindrajithkb
#8 3143852-login-after-patch.png56.04 KBindrajithkb
#8 3143852-login-before-patch.png45.63 KBindrajithkb
#5 Contact___Olivero_after_patch_4.png13.24 KBnitesh624
#5 Create_new_account___Olivero_after_patch_4.png52.56 KBnitesh624
#5 Log_in___Olivero_after_patch_4.png90.24 KBnitesh624
#4 3143852-4.patch609 bytesnitesh624
Log_in___Olivero.png46.12 KBmherchel
Create_new_account___Olivero.png74.17 KBmherchel
Contact___Olivero.png63.04 KBmherchel

Comments

mherchel created an issue. See original summary.

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Assigned: Unassigned » nitesh624
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 3143852-4.patch609 bytes
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new Log_in___Olivero_after_patch_4.png90.24 KB
new Create_new_account___Olivero_after_patch_4.png52.56 KB
new Contact___Olivero_after_patch_4.png13.24 KB

changes in login page after applying patch #4
Log_in___Olivero_after_patch_4

Create new account form after patch #4
Create new account after patch 4

Contact form after patch #4
Contact___Olivero_after_patch_4

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Status: Active » Needs review
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Assigned: nitesh624 » Unassigned
indrajithkb’s picture

indrajithkb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3143852-login-before-patch.png45.63 KB
new 3143852-login-after-patch.png56.04 KB
new 3143852-reset-pwd-before-patch.png72.95 KB
new 3143852-reset-pwd-after-patch.png73.53 KB

HI @nitesh624 thanks for the #4 patch and it's working perfectly. and thanks for the detailed testing from your end.

Here am just confirming again. Just went through all the forms and found issue only with login and reset password.

Login form:

Before patch

login-before

After patch

login-after

Reset password

Before patch

reset-pwd-before

After patch

reset-pwd-after

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Reviewed & tested by the community » Needs work

This is super close! I found a couple issues:

1. There should be indentation
2. It doesn't appear to be affecting the node search page at /search/node?keys=... not really sure why. I didn't troubleshoot it.

Other than that, it's looking good! Thanks :)

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Assigned: Unassigned » nitesh624
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Status: Needs work » Needs review
StatusFileSize
new 3143852-11.patch1.06 KB
new interdiff_4-11.txt1007 bytes
new search-form-basic-after-patch_11.png104.54 KB
new search-form-advanced-after-patch_11.png105.78 KB

Thanks @mherchel for reviewing
1. There should be indentation - fixed in patch #11
2. It doesn't appear to be affecting the node search page at /search/node?keys=... not really sure why. I didn't troubleshoot it. - fixed in patch #11 please refer the screenshot below

Search Basic form after patch #11

search-form-basic-after-patch_11

Search Advanced form after patch #11

search-form-advanced-after-patch_11

indrajithkb’s picture

indrajithkb commented
Assigned: nitesh624 » Unassigned

Hi @nitesh624 it's very nice. Perfectly done. Thanks for the #11.
Really appreciating the way you are working on the issue.
just confirming patches are working good not adding the screenshots again.

RTBC +1

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Fixed

Looks good. Committed! Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.