Create a separate CredentialFormTest

+++ b/core/modules/migrate_drupal_ui/tests/src/Functional/CredentialFormTest.php
@@ -0,0 +1,121 @@
+  /**
+   * {@inheritdoc}
+   */
+  protected function getAvailablePaths() {
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getEntityCounts() {
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getEntityCountsIncremental() {
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function getMissingPaths() {
+  }

I think we need to return the correct types here, empty arrays for most of them, I think.

Made the changes suggested in #15. Thankyou for the help @quietone!

RTBC pending tests.

Reran test on #18, previous failure seemed to be random.

@ayushmishra206 Sorry, had an old window open, resetting status to RTBC on #18 as per #19 by Mike Lutz

@Spokje, since there was a new patch, in #23, I don't see why the tests were rerun on the patch in #18. And, of course, not rerunning tests will save on resources.

@quietone, I started the rerun of the test on #18 when your comment #19 was the latest entry and the first testbot run on it seemed to be a random failure.
When the test was finished (this time successful, so it was a false positive) I didn't reload my open browser-tab and didn't notice the (identical, so not so) new patches. Hence my comment #25 which is now completely out of sync.

Besides the above: You're completely right (as usual :)

I am sorry for creating this much of confusion. I have made the changes suggested in #26. Please review

fixed the coding standards error.

Okay, looks right now.

Reroll of patch #32

@quietone Sorry, had actually created an interdiff, but forgot to upload it. Here it is now.

I think since it's a reroll this can be RTBC per #33, but I've been bitten before after rerolling and RTBC-ing it myself, so I'll leave this on NR for now.

As far as git is concerned, this is a very routine reroll: a few lines of context were removed from MigrateUpgradeExecuteTestBase.php in #3143721: Create a separate SourceProviderTest, and that is the only difference between the patches in #32 and #38.

I still want to look a little closer to make sure that the patch makes sense in that context.

I am glad I decided to take a closer look. There is nothing wrong with the reroll, but this hunk is redundant:

+++ b/core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeTestBase.php
@@ -43,6 +43,10 @@ abstract class MigrateUpgradeTestBase extends BrowserTestBase {
    */
   protected function setUp() {
     parent::setUp();
+
+    // Get the current major version.
+    [$this->destinationSiteVersion] = explode('.', \Drupal::VERSION, 2);
+
     $this->createMigrationConnection();
     $this->sourceDatabase = Database::getConnection('default', 'migrate_drupal_ui');

Thanks for cleaning up the tests. They have to be maintainable, too!

Mmm, what's cooking?

Thanks for the updated patch. Back to RTBC.

Committed 1e03b1c and pushed to 9.1.x. Thanks!