Claro + layout builder side-bar off-canvas dialogs list item background color

Hi @davidferlay i have added the changes (from this patch https://www.drupal.org/project/drupal/issues/2986056 ) here also, but still our issue is here, so i am keeping this change and fixed the issue(hope this you need). Please review my patch.

Before:

After:

Hi @davidferlay ,
when am trying to click "Create Custom Block" to reproduce am getting the below window.

i have created the custom blocks, but still i am getting this screen.

I tested the steps in the issue summary and this works as expected for me. Can anyone else reproduce this?

I reproduced that issue with multiple block_types against drupal 8.9.0 and these problems comes from layout-builder.css which is here /core/themes/stable/css/layout_builder/layout-builder.css

The following patch should solve your issue @davidferlay against 8.9.0, but it is more likely temporary fix.

Tested patch form #13 and result is NOT OK for mobile - there is no background

taking this up.

Not able to reproduce the issue on 8.9.x, here i am attaching screenshot(desktop, tab & mobile) which all are working fine. After applying patch #13 onHover of list item background is getting transparent and which is fine. I think there is no other issues in it, feel free to add your opinion.

Thanks!

Improved my patch from #13.
And again - it is temporary fix, which shouldn't be included in Claro globally.

Tested patch from #20 in different browsers for mobile and desktop and result is OK

Switching this back to needs work for the following reasons:

1. I'm not able to reproduce the issue following the steps in the issue summary. Th#19 and #10 were similarly unable to reproduce the issue. The issue summary should be updated with the steps necessary to reproduce the issue on a new Drupal install, with either the standard or Umami profile. Committers will not approve a patch without a consistent, reliable way to reproduce an issue, so this should absolutely be the next step before any other work happens.
2. After applying the patch, the dialog styling is broken in several ways. Screenshots are attached.
3. The "after" screenshots in #5 and #21 show a the off-canvas dialog with a white background. That isn't the correct styling, the background is supposed to be #444. The issue summary incorrectly says the solution should be a white background, so tagging with "needs issue summary update". This is how the dialog should appear (and in my case, does appear, as I'm not experiencing the symptoms)
   

I'm looking forward to the steps to reproduce, this looks like an interesting one.

I can confirm that I cannot reproduce the issue as well.

I am on Drupal 9.0.1

I have implemented my own OpenOffCanvasDialogCommand in an ajax response.
This use case creates also the empty background issue for me in drupal 8.9

It seems it's because background is set to none, en a padding exists for the content within the dialog.

.ui-dialog.ui-dialog-off-canvas .ui-widget-content.ui-dialog-content {
  background: none;
}

.ui-dialog .ui-widget-content.ui-dialog-content {
  overflow: auto;
  padding: 1em;
  background: #fff;
}

This issues also occurs therefor in Gin theme.

The screenshot in #26 may be evidence that a problem is being experienced, but does not provide any information on how to reproduce. This issue can't be set to active unless there are specific steps for how to reproduce the issue in Drupal core. If we can follow steps to get to the same symptoms as the ones in the screenshot, things can move forward!

Closing as outdated since there hasn't been a follow since moving to PNMI 2 years ago

if you still feel this is an issue please reopen providing the information requested in #27 with updated issue summary and testing steps.

Filed a new related issue.