Drupal 9 Readiness

Here's a minimal test that verifies that the form element works as designed (additional test coverage should be added, but this is a start). Once the core_version_requirement is committed to the project, this test should pass when run against Drupal 9 core.

You should have combined the two patches. Now you have one that adds the compatibility and one that adds the test.

While it is conventional to only make one commit per issue, it is acceptable to make multiple commits before marking an issue as fixed.

In this case, I believe that is the preferable strategy since, as I say above, the core_version_requirement must be first committed to the project before the tests can be run with Drupal 9.0 core.

In other words, in order to demonstrate successful, passing tests via the Drupal test runner, we must make two commits.

Ah that I didn't know ;) test looks great, and the other patch as well. So I would say RTBC.

Hey guys, great work!

I've committed the drupal 9 requirement to the info.yml file and released beta3: https://www.drupal.org/project/media_library_form_element/releases/8.x-1... so the automated test can run.

I've reviewed the test-patch and want to first test it out myself before actually committing it. I did commit it to the dev-branch of the module, should you want to review it as well (https://git.drupalcode.org/project/media_library_form_element/-/commit/9...)

I've changed the test-module's name to "media_library_form_element_test" (singular) cfr. "media_library_test".

I personally have little PHPUnit experience, let alone FunctionalJavascript testing etc, so I've first need to get my test-groove on :-)

@marc should you have any pointers on steps to run the test in a local sandbox project... they're welcome ;-)

Greets,
Kim

I will create a new Issue to flesh uit any tests.

https://www.drupal.org/project/media_library_form_element/issues/3151675 for the tests

Great work!